<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114874/">https://git.reviewboard.kde.org/r/114874/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Aleix Pol Gonzalez.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2014, 3:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed the "Qt5: Drop QtGui/ prefix from includes" commit. This is a no-brainer anyway and just clutters the review.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Qt5: Initial port to KF5-based build system
Port away from CMake code provided by kdelibs and use macros from the
ECM package.
Not in a compilable state atm. Just touched the build system.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(9b10bbad4eb17d636210749b3952970e2eb4857e)</span></li>
<li>debugger/CMakeLists.txt <span style="color: grey">(bec440d140b318b13bf6b596d6a5beedf5062ae6)</span></li>
<li>documentation/CMakeLists.txt <span style="color: grey">(83c55c4d9e6661843dd059d79ceced9f27aaafc4)</span></li>
<li>interfaces/CMakeLists.txt <span style="color: grey">(5bb02b229a91b618d6bf5441ff76379e53d8ab0d)</span></li>
<li>interfaces/tests/CMakeLists.txt <span style="color: grey">(32124fa6417f81484e12f701175334961390d786)</span></li>
<li>language/CMakeLists.txt <span style="color: grey">(72ab78e368907f274fcd93a9e2acf862ab29b67f)</span></li>
<li>language/backgroundparser/tests/CMakeLists.txt <span style="color: grey">(f07758e2131a6c672369aecec4173fac6aa08554)</span></li>
<li>language/codegen/tests/CMakeLists.txt <span style="color: grey">(a168f9c9629709d8182f8019e3d55745d15f8560)</span></li>
<li>language/duchain/tests/CMakeLists.txt <span style="color: grey">(20cc76b74f13229341458060403383c5809b58a1)</span></li>
<li>language/duchain/tests/serialization/CMakeLists.txt <span style="color: grey">(f82ffbdaf9c7a73c213fd82fd33bc4fb9d9e6649)</span></li>
<li>language/highlighting/tests/CMakeLists.txt <span style="color: grey">(559144c192fa2a6084304ef28034fa98372d7565)</span></li>
<li>outputview/CMakeLists.txt <span style="color: grey">(b15d640f4486e863dd90caa8560f9c332cc66810)</span></li>
<li>outputview/tests/CMakeLists.txt <span style="color: grey">(321e8a3a2a3c88648af38b22e9d2de2d4803b49e)</span></li>
<li>plugins/CMakeLists.txt <span style="color: grey">(e0ccbc123e8113ea3a552c06db2a7833b07782cc)</span></li>
<li>plugins/appwizard/CMakeLists.txt <span style="color: grey">(d2714ca715d9e6fa577b0dcbd7831cc52dbc4fa3)</span></li>
<li>plugins/classbrowser/CMakeLists.txt <span style="color: grey">(25542c09d8693db9897d50756b6e706099bc86b3)</span></li>
<li>plugins/codeutils/CMakeLists.txt <span style="color: grey">(c5a06c4ea15a423e592ef5793621eab7ea2dd9ba)</span></li>
<li>plugins/codeutils/tests/CMakeLists.txt <span style="color: grey">(da38e25fd1be8429f31590383db77eabcc71e948)</span></li>
<li>plugins/contextbrowser/CMakeLists.txt <span style="color: grey">(8bd52cc6332d1cbec1aecf36ae6df75492d9d81f)</span></li>
<li>plugins/cvs/CMakeLists.txt <span style="color: grey">(dbc3af7f39b125ba35f971f8314da44beff98fb1)</span></li>
<li>plugins/cvs/tests/CMakeLists.txt <span style="color: grey">(1ef17464d313d2a9219ef91cd87bd7f3032acf5b)</span></li>
<li>plugins/dashboard/CMakeLists.txt <span style="color: grey">(f3b606d17fd46e80b755e321b9dde42be1b6a298)</span></li>
<li>plugins/dashboard/declarative/CMakeLists.txt <span style="color: grey">(0d5cfa40734ef134fcbebdb383cf26891c5c3a26)</span></li>
<li>plugins/dashboard/plasmoids/projectfileplasmoid/CMakeLists.txt <span style="color: grey">(d3016d73b581e4a2e470325853c42f5b47b50f38)</span></li>
<li>plugins/documentswitcher/CMakeLists.txt <span style="color: grey">(37574d04c29459bfce3935cd5ef7ee7b35c14d44)</span></li>
<li>plugins/documentview/CMakeLists.txt <span style="color: grey">(57daa63a6d8d1b242b853cc599f88ff7bd2583db)</span></li>
<li>plugins/documentview/settings/CMakeLists.txt <span style="color: grey">(f62c7ce6fd688a4a1c0c1af9f9f43ddf096d73e9)</span></li>
<li>plugins/execute/CMakeLists.txt <span style="color: grey">(5313b7b88ed879aad6ee57c01b63c477da578f66)</span></li>
<li>plugins/executescript/CMakeLists.txt <span style="color: grey">(bcd7d41289af6525f57c4e8743f519bf617c6ac2)</span></li>
<li>plugins/externalscript/CMakeLists.txt <span style="color: grey">(90afcfa7142e4ac2f2af31117b86443d450ce6af)</span></li>
<li>plugins/filemanager/CMakeLists.txt <span style="color: grey">(08d90741c540ccd74a70786b9cd0c15e8759198d)</span></li>
<li>plugins/filetemplates/CMakeLists.txt <span style="color: grey">(f9a16ecc480ff52589e15ee9fbbd3131f833fea7)</span></li>
<li>plugins/genericprojectmanager/CMakeLists.txt <span style="color: grey">(7a7cce9e8165926f43a0def71df93f03dc41b5f4)</span></li>
<li>plugins/genericprojectmanager/test/CMakeLists.txt <span style="color: grey">(3cb7d726ec2904efba3287e0e1338db58982139f)</span></li>
<li>plugins/git/CMakeLists.txt <span style="color: grey">(05a261ba9e59a76d7def4c1cf2b3346692d9ba37)</span></li>
<li>plugins/git/icons/CMakeLists.txt <span style="color: grey">(dc4e8983269eba856556e14a8a5954c080400060)</span></li>
<li>plugins/git/tests/CMakeLists.txt <span style="color: grey">(b55df9d21f3ff2f55f9305db6474b57d60badb98)</span></li>
<li>plugins/grepview/CMakeLists.txt <span style="color: grey">(0a6308336ae275f4e9069112109aae4efae89fa9)</span></li>
<li>plugins/grepview/tests/CMakeLists.txt <span style="color: grey">(02b907899bb65d72fd0e4fd76fd6399aeafdb2c4)</span></li>
<li>plugins/konsole/CMakeLists.txt <span style="color: grey">(5f5ea53975fd1287986c5d3d8b7a9d85c10e5e5c)</span></li>
<li>plugins/openwith/CMakeLists.txt <span style="color: grey">(6c43a957232909806203042b045e488acb4c94fc)</span></li>
<li>plugins/pastebin/CMakeLists.txt <span style="color: grey">(efeef1f0d3d814db3b861e7d34c647f12689acfc)</span></li>
<li>plugins/patchreview/CMakeLists.txt <span style="color: grey">(ba150dcf8f672d6dc4a788acc720b639dfeb78d2)</span></li>
<li>plugins/patchreview/libdiff2/tests/CMakeLists.txt <span style="color: grey">(61ea7ef83dd244031cad41d3f1ed0a6119f373f4)</span></li>
<li>plugins/problemreporter/CMakeLists.txt <span style="color: grey">(ad1162e2e48f6a5ffdfafca7f434c8ec890d0817)</span></li>
<li>plugins/projectfilter/CMakeLists.txt <span style="color: grey">(8e5d0b956d085f77d0ed4db4f851dbe1b68bd81a)</span></li>
<li>plugins/projectfilter/tests/CMakeLists.txt <span style="color: grey">(bca35add561883269bd430e4cf5ef573c3ebfd19)</span></li>
<li>plugins/projectmanagerview/CMakeLists.txt <span style="color: grey">(1fc4ad9c5679319b7873817d0ea744767e1a5ac4)</span></li>
<li>plugins/quickopen/CMakeLists.txt <span style="color: grey">(19ce904073bb5a5bee7048bce82cbe6b82c38101)</span></li>
<li>plugins/quickopen/tests/CMakeLists.txt <span style="color: grey">(e967c79d2af886c423eeb8773171074756b89478)</span></li>
<li>plugins/reviewboard/CMakeLists.txt <span style="color: grey">(a6a2aeae99be8f468d7983c673de2f836b2e519e)</span></li>
<li>plugins/reviewboard/icons/CMakeLists.txt <span style="color: grey">(1cc07729d578a5524f873522338a46bb994a0f61)</span></li>
<li>plugins/reviewboard/tests/CMakeLists.txt <span style="color: grey">(f5fcc2a3e3d55474a174fd2dbb74105f92a6b144)</span></li>
<li>plugins/snippet/CMakeLists.txt <span style="color: grey">(e90d0ea6252b50e9638115f666d93d3f257f10a4)</span></li>
<li>plugins/standardoutputview/CMakeLists.txt <span style="color: grey">(88c0478f183b26f298d37be506dbe0f8d538a334)</span></li>
<li>plugins/standardoutputview/tests/CMakeLists.txt <span style="color: grey">(6267f4855310983a7c6de37f5a723d8a08feae38)</span></li>
<li>plugins/subversion/CMakeLists.txt <span style="color: grey">(70359fa4cf8a2235d93af7e9471bcae56fcc2500)</span></li>
<li>plugins/subversion/icons/CMakeLists.txt <span style="color: grey">(dc4e8983269eba856556e14a8a5954c080400060)</span></li>
<li>plugins/subversion/tests/CMakeLists.txt <span style="color: grey">(4744f9f516c6c4cd8fa061099c670747a0e1b9de)</span></li>
<li>plugins/switchtobuddy/CMakeLists.txt <span style="color: grey">(32898d48ec7f453b42a5d65f97d3d1e4ba97b97b)</span></li>
<li>plugins/templatemanager/CMakeLists.txt <span style="color: grey">(cc3ea92ec64d7fee1c355503ea6ff55dea6d400e)</span></li>
<li>plugins/testview/CMakeLists.txt <span style="color: grey">(9d6678a0788db04759a4bd8866ae289ad5135469)</span></li>
<li>plugins/vcschangesview/CMakeLists.txt <span style="color: grey">(0bc082a801b533a0b0f8d21ce5e46990f56d27b8)</span></li>
<li>project/CMakeLists.txt <span style="color: grey">(2e3ce8c1ddb1877d36509083bf78203c11893259)</span></li>
<li>project/tests/CMakeLists.txt <span style="color: grey">(57948f2811a565ddc8125c3b431c90f5379d87cf)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(862117e95da9f7502cb6b9a3c992789d4fab88ee)</span></li>
<li>shell/kross/xmltokross/CMakeLists.txt <span style="color: grey">(a050345be9a07543f2c9934bcaf03ef1764bd790)</span></li>
<li>shell/settings/CMakeLists.txt <span style="color: grey">(c66367f59c87e698f348d4be483784b08cad674c)</span></li>
<li>shell/tests/CMakeLists.txt <span style="color: grey">(79a433f2ae855ca1ac71c7b77e92a518fda65b7d)</span></li>
<li>sublime/CMakeLists.txt <span style="color: grey">(49cbd7f4f4bd33d733bc6450011ce9ab77f4f611)</span></li>
<li>sublime/examples/CMakeLists.txt <span style="color: grey">(b172b3b3672d0a9f9bc4dc090020bdb39b6c2a53)</span></li>
<li>sublime/tests/CMakeLists.txt <span style="color: grey">(c38d3070d39967903db3e2ec7ddd954b514c4b8b)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(36d74609d36e6bedeb57d94f30483dffc2a3bd95)</span></li>
<li>tests/json/CMakeLists.txt <span style="color: grey">(ed33687b20e7f1baab6f808d5a19ea99a76d6b14)</span></li>
<li>util/CMakeLists.txt <span style="color: grey">(cf2fc1a873ed902dabe65257293532064a9b42da)</span></li>
<li>util/dbus_socket_transformer/CMakeLists.txt <span style="color: grey">(dc4a61dae11e2abd9bede6089b4f07672173c34e)</span></li>
<li>util/duchainify/CMakeLists.txt <span style="color: grey">(40d5144d7ca274673b08556cdc929c3a84221f4c)</span></li>
<li>util/ssh_client/CMakeLists.txt <span style="color: grey">(d615ab67840759d54c62258e6c3032cf35559d7f)</span></li>
<li>util/tests/CMakeLists.txt <span style="color: grey">(fb538166e6e8d14cf7c8e473784492bfe27b99e4)</span></li>
<li>vcs/CMakeLists.txt <span style="color: grey">(e1d935bf222623e24cefb97da72aff7ce33cace4)</span></li>
<li>vcs/dvcs/tests/CMakeLists.txt <span style="color: grey">(07f689bd9ef662a2bc4ad86ef028d591b6a3bfe9)</span></li>
<li>vcs/models/tests/CMakeLists.txt <span style="color: grey">(e6b6942d242ee733378ada9751a08b411a28fe2f)</span></li>
<li>vcs/tests/CMakeLists.txt <span style="color: grey">(9cb05773683adf880aa1dd4f0edd3ec2c5c1f47c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114874/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>