Review Request 114753: RFC: Dynamic layouts for some tool view widgets

[Vlas Puhov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114753/#review46531
-----------------------------------------------------------


Looks good!
  I wonder if you could make disassembleWidget use this feature too (if not, I'll do it later then).
  Also, can we somehow reuse this code from resizeEvent? E.g. by implementing an intermediate class from QSplitter, which'll handle all that resize stuff. And inherit all other widgets that use splitter from it?

- Vlas Puhov


On Dec. 31, 2013, 5:12 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114753/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2013, 5:12 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> RFC: Dynamic layouts for some tool view widgets
> 
> Support added for the break point and frame stack widget for now.
> 
> My first idea was to add API to KDevelop::IToolViewFactory and friends in order to support something like dynamic layouts in the tool views. But then I thought: We can have this much easier -- just let the *widget* contained in the dock decide how to layout its children and don't even touch the glue code for tool views.
> 
> Comments?
> 
> 
> Diffs
> -----
> 
>   debugger/breakpoint/breakpointwidget.h c5f3f6b6cc92385c9e07e5c4ceb185db15817edd 
>   debugger/breakpoint/breakpointwidget.cpp d180181e2306c9aa8c6f8b596d84857f3acb1ba3 
>   debugger/framestack/framestackwidget.h 60d4a155b4ba0edaa63375f22ab3cff1f12fca9c 
>   debugger/framestack/framestackwidget.cpp d339472e8464933e5b2fb5048cb73ce54e881e95 
> 
> Diff: https://git.reviewboard.kde.org/r/114753/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> kdevelop-dynamic-layouts_before.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/12/31/0585b34d-c2d5-4093-807d-e912fd5dff35__kdevelop-dynamic-layouts_before.png
> kdevelop-dynamic-layouts_after.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/12/31/19b3b1a5-25b8-4997-b0b0-61c2f3b2421a__kdevelop-dynamic-layouts_after.png
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140101/f8ea4f9c/attachment.html>