<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114753/">https://git.reviewboard.kde.org/r/114753/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good!
I wonder if you could make disassembleWidget use this feature too (if not, I'll do it later then).
Also, can we somehow reuse this code from resizeEvent? E.g. by implementing an intermediate class from QSplitter, which'll handle all that resize stuff. And inherit all other widgets that use splitter from it?</pre>
<br />
<p>- Vlas Puhov</p>
<br />
<p>On December 31st, 2013, 5:12 p.m. MSK, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2013, 5:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">RFC: Dynamic layouts for some tool view widgets
Support added for the break point and frame stack widget for now.
My first idea was to add API to KDevelop::IToolViewFactory and friends in order to support something like dynamic layouts in the tool views. But then I thought: We can have this much easier -- just let the *widget* contained in the dock decide how to layout its children and don't even touch the glue code for tool views.
Comments?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debugger/breakpoint/breakpointwidget.h <span style="color: grey">(c5f3f6b6cc92385c9e07e5c4ceb185db15817edd)</span></li>
<li>debugger/breakpoint/breakpointwidget.cpp <span style="color: grey">(d180181e2306c9aa8c6f8b596d84857f3acb1ba3)</span></li>
<li>debugger/framestack/framestackwidget.h <span style="color: grey">(60d4a155b4ba0edaa63375f22ab3cff1f12fca9c)</span></li>
<li>debugger/framestack/framestackwidget.cpp <span style="color: grey">(d339472e8464933e5b2fb5048cb73ce54e881e95)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114753/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/12/31/0585b34d-c2d5-4093-807d-e912fd5dff35__kdevelop-dynamic-layouts_before.png">kdevelop-dynamic-layouts_before.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/12/31/19b3b1a5-25b8-4997-b0b0-61c2f3b2421a__kdevelop-dynamic-layouts_after.png">kdevelop-dynamic-layouts_after.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>