Review Request 115707: Select new project name and location separately

[Michael Ferris]

> On Feb. 17, 2014, 9:03 p.m., Milian Wolff wrote:
> > plugins/appwizard/projectselectionpage.cpp, line 230
> > <https://git.reviewboard.kde.org/r/115707/diff/1/?file=243798#file243798line230>
> >
> >     why are these changes required?

Because  according to QDir::cdUp() 
Returns true if the new directory exists and is readable; otherwise returns false. Note that the logical cdUp() operation is not performed if the new directory does not exist.

Since we want to go up the path until an existing directory is found, we have to perform the cdUp operation manually.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115707/#review50096
-----------------------------------------------------------


On Feb. 18, 2014, 5:51 p.m., Michael Ferris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115707/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2014, 5:51 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 282783
>     http://bugs.kde.org/show_bug.cgi?id=282783
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Update in real time the actual location for the creation of the project.
> Can manually edit the location for a preferred location and keep the project name as desired.
> 
> Keeps the percent encoding by default.
> 
> 
> Diffs
> -----
> 
>   plugins/appwizard/projectselectionpage.h 7aeef58ca8d1f57b5b025bbccf59560d58d48d0d 
>   plugins/appwizard/projectselectionpage.cpp 62708695c83e8de59ed77d778a3a63a89b32ed52 
> 
> Diff: https://git.reviewboard.kde.org/r/115707/diff/
> 
> 
> Testing
> -------
> 
> Creation of project with special character and manually change the location to remove them.
> Creation of project at deeper level of inexistant directories  ie:  /home/src/project/project1/myProject   with  /home/src currently existing
> 
> 
> Thanks,
> 
> Michael Ferris
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140218/cbbaa765/attachment.html>