Review Request 115707: Select new project name and location separately

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115707/#review50096
-----------------------------------------------------------



plugins/appwizard/projectselectionpage.h
<https://git.reviewboard.kde.org/r/115707/#comment35186>

    remove trailing spaces



plugins/appwizard/projectselectionpage.h
<https://git.reviewboard.kde.org/r/115707/#comment35185>

    please remove the do prefix here



plugins/appwizard/projectselectionpage.cpp
<https://git.reviewboard.kde.org/r/115707/#comment35187>

    use initializer list for this and break the existing one before the comma, so that you have:
    
    PSP::PSP(...)
        : AWPW(parent)
        , m_templatesModel(...);
        , ...
    {
    
    }



plugins/appwizard/projectselectionpage.cpp
<https://git.reviewboard.kde.org/r/115707/#comment35188>

    remove this unrelated change please



plugins/appwizard/projectselectionpage.cpp
<https://git.reviewboard.kde.org/r/115707/#comment35190>

    add a blank line inbetween please



plugins/appwizard/projectselectionpage.cpp
<https://git.reviewboard.kde.org/r/115707/#comment35191>

    could you add some comment in front of this loop, or better yet - extract it into a free function with a meaningful name? what is this trying to do?



plugins/appwizard/projectselectionpage.cpp
<https://git.reviewboard.kde.org/r/115707/#comment35193>

    why are these changes required?



plugins/appwizard/projectselectionpage.cpp
<https://git.reviewboard.kde.org/r/115707/#comment35194>

    "... , valid characters are: \"a-z\", \"A-Z\", \"0-9\" and \"-_+%.\"."


- Milian Wolff


On Feb. 12, 2014, 9:48 p.m., Michael Ferris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115707/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 9:48 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 282783
>     http://bugs.kde.org/show_bug.cgi?id=282783
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Update in real time the actual location for the creation of the project.
> Can manually edit the location for a preferred location and keep the project name as desired.
> 
> Keeps the percent encoding by default.
> 
> 
> Diffs
> -----
> 
>   plugins/appwizard/projectselectionpage.cpp 62708695c83e8de59ed77d778a3a63a89b32ed52 
>   plugins/appwizard/projectselectionpage.h 7aeef58ca8d1f57b5b025bbccf59560d58d48d0d 
> 
> Diff: https://git.reviewboard.kde.org/r/115707/diff/
> 
> 
> Testing
> -------
> 
> Creation of project with special character and manually change the location to remove them.
> Creation of project at deeper level of inexistant directories  ie:  /home/src/project/project1/myProject   with  /home/src currently existing
> 
> 
> Thanks,
> 
> Michael Ferris
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140217/86646d46/attachment.html>