Review Request 115638: a test for use builder

[Matija Skala]

> On Feb. 11, 2014, 11:32 a.m., Milian Wolff wrote:
> > duchain/tests/javausetest.cpp, line 64
> > <https://git.reviewboard.kde.org/r/115638/diff/1/?file=243144#file243144line64>
> >
> >     no need to add this function to the header, just make it a free function in an anonymous namespace in the .cpp file.
> >     
> >     also note, that we put * and & next to the typename, so please write this as "const QString& code"

if i remove it from the header i'll have to do the same with createdFiles. should i do this?


- Matija


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115638/#review49525
-----------------------------------------------------------


On Feb. 11, 2014, 1 p.m., Matija Skala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115638/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 1 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-java
> 
> 
> Description
> -------
> 
> to check if it correctly finds variable uses
> 
> 
> Diffs
> -----
> 
>   duchain/tests/CMakeLists.txt cd2bd7b 
>   duchain/tests/javausetest.h PRE-CREATION 
>   duchain/tests/javausetest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115638/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matija Skala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140211/0b57a997/attachment-0001.html>