Review Request 115638: a test for use builder

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115638/#review49525
-----------------------------------------------------------

Ship it!


Again, some nitpicks but otherwise good work - thanks!


duchain/tests/javausetest.cpp
<https://git.reviewboard.kde.org/r/115638/#comment34926>

    move this to cleanup(), which will then be called after every test function. Also call createdFiles.clear() afterwards.



duchain/tests/javausetest.cpp
<https://git.reviewboard.kde.org/r/115638/#comment34929>

    no need to add this function to the header, just make it a free function in an anonymous namespace in the .cpp file.
    
    also note, that we put * and & next to the typename, so please write this as "const QString& code"



duchain/tests/javausetest.cpp
<https://git.reviewboard.kde.org/r/115638/#comment34924>

    remove the else, and replace Q_ASSERT with a Q_ASSERT_X(false, Q_FUNC_INFO, "Timed out...")



duchain/tests/javausetest.cpp
<https://git.reviewboard.kde.org/r/115638/#comment34927>

    if you don't need it, don't add this function


- Milian Wolff


On Feb. 11, 2014, 3:39 a.m., Matija Skala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115638/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 3:39 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-java
> 
> 
> Description
> -------
> 
> to check if it correctly finds variable uses
> 
> 
> Diffs
> -----
> 
>   duchain/tests/CMakeLists.txt cd2bd7b 
>   duchain/tests/javausetest.h PRE-CREATION 
>   duchain/tests/javausetest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115638/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matija Skala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140211/6ef0377a/attachment.html>