Break Custom Buildsystem Plugin apart into 2 pieces.

[Milian Wolff]

On Monday 10 February 2014 16:02:41 Sergey Kalinichev wrote:
> Hi,
> 
> While working on https://bugs.kde.org/show_bug.cgi?id=329788 bug, I came
> across the Custom Buildsystem Plugin that already implements this feature
> (define macros manually). After further investigation I've come to
> conclusion that reusing plugin's code could also solve the
> https://bugs.kde.org/show_bug.cgi?id=254662 bug.
> 
> So here the questions:
> 1. What is it plugin for? Why is it disabled by default? (I had to modify
> *.kde4 file to enable it)

It is a project manager. You open a project with it and then can define the 
macros, includes but also targets etc. pp.

> 2. Do you think it's a good idea to refactor that pugin into 2 parts one of
> which will become "Custom Defines and Includes" plugin, that could be used
> by all project managers (or directly by language plugins?) to retrieve
> custom includes/defines?

Yes, makes sense. The definition of targets etc. pp. should be kept in the 
project manager though. But feel free to extract the includepath manager from 
the old C++ plugin into this new plugin as well then.

> 3. If it's, where to store includes/defines then? Currently we use
> .kdev_include_paths, but Custom Buildsystem uses *.kde4 file for that. So
> which one to choose?

For files opened outside of a project, this should still work so we cannot 
store it in a project configuration. Imo, putting it into the file system 
would be OK but then you'll get problems in detecting them and putting it into 
a nice GUI for later configuration...

Suggestions anyone?


-- 
Milian Wolff
mail at milianw.de
http://milianw.de