Review Request 115538: Revert 3fb09793

[Sven Brauch]

> On Feb. 7, 2014, 4:12 p.m., Sven Brauch wrote:
> > Hmm, that doesn't look right to me.
> > Doesn't the context builder inherit from the AST visitor already? That's how other languages do it. I think you should do that too, if it's not the case already.
> > 
> > How is this related to usingDeclaration()?
> 
> Matija Skala wrote:
>     Yes, it does inherit from AST visitor just like in the other languages.
>     
>     usingDeclaration is virtual function in AbstractExpressionVisitor which used to be overriden in UseBuilder.

What's the point of the expression visitor inheriting from the context builder? I think that's a mistake already.

Maybe you want to come to #kdevelop on irc.freenode.net? I imagine it might be easier to discuss this there.


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115538/#review49207
-----------------------------------------------------------


On Feb. 7, 2014, 4:06 p.m., Matija Skala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115538/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2014, 4:06 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-java
> 
> 
> Description
> -------
> 
> UseBuilder has to be based on AbstractExpressionVisitor so that UseBuilder::usingDeclaration can be useful.
> 
> 
> Diffs
> -----
> 
>   duchain/usebuilder.h 3945153 
> 
> Diff: https://git.reviewboard.kde.org/r/115538/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matija Skala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140207/15232491/attachment.html>