Review Request 115538: Revert 3fb09793

[Matija Skala]

> On Feb. 7, 2014, 5:12 p.m., Sven Brauch wrote:
> > Hmm, that doesn't look right to me.
> > Doesn't the context builder inherit from the AST visitor already? That's how other languages do it. I think you should do that too, if it's not the case already.
> > 
> > How is this related to usingDeclaration()?

Yes, it does inherit from AST visitor just like in the other languages.

usingDeclaration is virtual function in AbstractExpressionVisitor which used to be overriden in UseBuilder.


- Matija


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115538/#review49207
-----------------------------------------------------------


On Feb. 7, 2014, 5:06 p.m., Matija Skala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115538/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2014, 5:06 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-java
> 
> 
> Description
> -------
> 
> UseBuilder has to be based on AbstractExpressionVisitor so that UseBuilder::usingDeclaration can be useful.
> 
> 
> Diffs
> -----
> 
>   duchain/usebuilder.h 3945153 
> 
> Diff: https://git.reviewboard.kde.org/r/115538/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matija Skala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140207/f8c1e65c/attachment.html>