Review Request 115533: Introduce NativeAppErrorFilteringStrategy

[Sven Brauch]

> On Feb. 7, 2014, 10:42 a.m., Sven Brauch wrote:
> > Good idea, but do you intend to put all the detectable error messages for all the frameworks into one strategy? It might be worth thinking about whether that's a good idea (but I think it is). Otherwise, you might want to make this a Qt filtering strategy ...?
> > But I guess it doesn't have any substantial advantage over putting them all together, so go for it ;)
> > 
> > (In fact I'm unsure about the concept of filtering strategies anyways. We could just put all the possible filters into the same strategy, that'd probably work just as well, and would be much easier for the user)
> 
> Kevin Funk wrote:
>     I was thinking about the same of course, in fact I had a Qt-specific one in mind at first. But I think it's quite difficult for the user to figure out that he a) *has* to configure it in order to make it work for his specific application, b) where to configure it. So I think the generic approach is better here.
>     
>     Regarding your second point: I fear that this will slow down the output model quite a bit. Lots of the regexps (e.g. for parsing compiler output) are very expensive, so it probably makes sense to use those for a specific task only.
>     
>

Yeah, the speed is the obvious pitfall of course. And in cases where kdevelop knows which strategy is applicable (e.g. compiling) it makes sense to limit it to that strategy.

So yes, I guess the idea of having one default strategy for a specific launch type (as is the case for scripts too since recently) is indeed the way to go.


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115533/#review49171
-----------------------------------------------------------


On Feb. 7, 2014, 10:33 a.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115533/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2014, 10:33 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 329953
>     http://bugs.kde.org/show_bug.cgi?id=329953
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Introduce NativeAppErrorFilteringStrategy
> 
> It's now possible to jump to runtime output error messages, such as
> those from Qt:
> 
> Example (clickable) message:
> ASSERT: "errors().isEmpty()" in file /tmp/foo/bar.cpp, line 49
> 
> BUG: 329953
> 
> 
> I'm going to extend this as soon as I encounter more detectable lines.
> 
> 
> Diffs
> -----
> 
>   outputview/tests/filteringstrategytest.h 38a4deae1470432868d041bc57eab66e70b41391 
>   outputview/tests/filteringstrategytest.cpp f3cf632e8934872077ffc1279d54866e2a151b9d 
>   plugins/execute/nativeappjob.cpp 4987e35334c177efe0d2b4db8244982d5ed4e0a3 
>   outputview/outputfilteringstrategies.cpp f2e65e115644d04d1bb362d31d30d149a8071d00 
>   outputview/outputmodel.h dee7a911d8bda0a8178be205472016371bc92942 
>   outputview/outputmodel.cpp fcd5df5fb2b08e031e0e24aa4856effae7caed12 
>   outputview/outputfilteringstrategies.h 43c63bbf43f8dac44beffb70ddd8b7588677e235 
> 
> Diff: https://git.reviewboard.kde.org/r/115533/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140207/9cfb57f2/attachment-0001.html>