<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115533/">https://git.reviewboard.kde.org/r/115533/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 7th, 2014, 10:42 a.m. UTC, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good idea, but do you intend to put all the detectable error messages for all the frameworks into one strategy? It might be worth thinking about whether that's a good idea (but I think it is). Otherwise, you might want to make this a Qt filtering strategy ...?
But I guess it doesn't have any substantial advantage over putting them all together, so go for it ;)
(In fact I'm unsure about the concept of filtering strategies anyways. We could just put all the possible filters into the same strategy, that'd probably work just as well, and would be much easier for the user)</pre>
</blockquote>
<p>On February 7th, 2014, 10:54 a.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was thinking about the same of course, in fact I had a Qt-specific one in mind at first. But I think it's quite difficult for the user to figure out that he a) *has* to configure it in order to make it work for his specific application, b) where to configure it. So I think the generic approach is better here.
Regarding your second point: I fear that this will slow down the output model quite a bit. Lots of the regexps (e.g. for parsing compiler output) are very expensive, so it probably makes sense to use those for a specific task only.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, the speed is the obvious pitfall of course. And in cases where kdevelop knows which strategy is applicable (e.g. compiling) it makes sense to limit it to that strategy.
So yes, I guess the idea of having one default strategy for a specific launch type (as is the case for scripts too since recently) is indeed the way to go.</pre>
<br />
<p>- Sven</p>
<br />
<p>On February 7th, 2014, 10:33 a.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Feb. 7, 2014, 10:33 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=329953">329953</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Introduce NativeAppErrorFilteringStrategy
It's now possible to jump to runtime output error messages, such as
those from Qt:
Example (clickable) message:
ASSERT: "errors().isEmpty()" in file /tmp/foo/bar.cpp, line 49
BUG: 329953
I'm going to extend this as soon as I encounter more detectable lines.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>outputview/tests/filteringstrategytest.h <span style="color: grey">(38a4deae1470432868d041bc57eab66e70b41391)</span></li>
<li>outputview/tests/filteringstrategytest.cpp <span style="color: grey">(f3cf632e8934872077ffc1279d54866e2a151b9d)</span></li>
<li>plugins/execute/nativeappjob.cpp <span style="color: grey">(4987e35334c177efe0d2b4db8244982d5ed4e0a3)</span></li>
<li>outputview/outputfilteringstrategies.cpp <span style="color: grey">(f2e65e115644d04d1bb362d31d30d149a8071d00)</span></li>
<li>outputview/outputmodel.h <span style="color: grey">(dee7a911d8bda0a8178be205472016371bc92942)</span></li>
<li>outputview/outputmodel.cpp <span style="color: grey">(fcd5df5fb2b08e031e0e24aa4856effae7caed12)</span></li>
<li>outputview/outputfilteringstrategies.h <span style="color: grey">(43c63bbf43f8dac44beffb70ddd8b7588677e235)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115533/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>