Review Request 121681: Fix compilation
Jakub Caban
kuba at whyblack.pl
Fri Dec 26 16:03:16 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121681/
-----------------------------------------------------------
(Updated Dec. 26, 2014, 4:03 p.m.)
Review request for KDevelop.
Changes
-------
Changes per comment from Alex.
Repository: kdev-upload
Description
-------
Just a few porting bits to make it compile again without KDELibs4Support:
- port away from KIcon
- port away from KIO::NetAccess
- kDebug() -> qDebug() (actually I've enforced kDebug(int) -> qDebug() as I found no reason to keep that categorization in one place. If I'm mistaken let me know)
Diffs (updated)
-----
allprofilesmodel.cpp 3ee6053
kdevuploadplugin.cpp 3f05752
profilesfiletree.cpp 45152f6
tests/permissions.cpp 1837838
uploaddialog.cpp 8d0c7a1
uploadjob.cpp ebe556b
uploadpreferences.cpp 1fe0d72
uploadprofiledlg.cpp ac0fba2
uploadprofileitem.cpp f957ce4
uploadprofilemodel.cpp bc5153f
uploadprojectmodel.cpp c7ddacf
Diff: https://git.reviewboard.kde.org/r/121681/diff/
Testing
-------
Compiles and works in simple cases I've tried.
Thanks,
Jakub Caban
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141226/3bf0822d/attachment.html>
More information about the KDevelop-devel
mailing list