<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121681/">https://git.reviewboard.kde.org/r/121681/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Jakub Caban.</div>
<p style="color: grey;"><i>Updated Dec. 26, 2014, 4:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changes per comment from Alex.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-upload
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just a few porting bits to make it compile again without KDELibs4Support:
- port away from KIcon
- port away from KIO::NetAccess
- kDebug() -> qDebug() (actually I've enforced kDebug(int) -> qDebug() as I found no reason to keep that categorization in one place. If I'm mistaken let me know)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiles and works in simple cases I've tried.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>allprofilesmodel.cpp <span style="color: grey">(3ee6053)</span></li>
<li>kdevuploadplugin.cpp <span style="color: grey">(3f05752)</span></li>
<li>profilesfiletree.cpp <span style="color: grey">(45152f6)</span></li>
<li>tests/permissions.cpp <span style="color: grey">(1837838)</span></li>
<li>uploaddialog.cpp <span style="color: grey">(8d0c7a1)</span></li>
<li>uploadjob.cpp <span style="color: grey">(ebe556b)</span></li>
<li>uploadpreferences.cpp <span style="color: grey">(1fe0d72)</span></li>
<li>uploadprofiledlg.cpp <span style="color: grey">(ac0fba2)</span></li>
<li>uploadprofileitem.cpp <span style="color: grey">(f957ce4)</span></li>
<li>uploadprofilemodel.cpp <span style="color: grey">(bc5153f)</span></li>
<li>uploadprojectmodel.cpp <span style="color: grey">(c7ddacf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121681/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>