Review Request 121629: Port to .json from .desktop meta data file.
Kevin Funk
kfunk at kde.org
Mon Dec 22 09:11:16 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121629/#review72411
-----------------------------------------------------------
Ship it!
But in general: LGTM
- Kevin Funk
On Dec. 22, 2014, 1:05 a.m., Milian Wolff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121629/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2014, 1:05 a.m.)
>
>
> Review request for KDevelop and Burkhard Lück.
>
>
> Repository: kdev-clang
>
>
> Description
> -------
>
> Port to .json from .desktop meta data file.
>
>
> Diffs
> -----
>
> CMakeLists.txt 98ac12487ca7219e36c5ef5ea2ef06f4e2bd089c
> clangsupport.cpp 43f5306a2f994f207fcec90c76241ecbd1cdbcb5
> documentfinderhelpers.h 05eaceb278195e192d2320d02e8fe87add69164d
> documentfinderhelpers.cpp 2cdcbe690597648b864241dad74b6268c73cb94e
> kdevclangsupport.desktop.cmake ad186bd17f90f6557f380cbe268de6db58485ea4
> kdevclangsupport.json PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/121629/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Milian Wolff
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141222/53a7825b/attachment.html>
More information about the KDevelop-devel
mailing list