<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121629/">https://git.reviewboard.kde.org/r/121629/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But in general: LGTM</p></pre>
<br />
<p>- Kevin Funk</p>
<br />
<p>On December 22nd, 2014, 1:05 a.m. UTC, Milian Wolff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop and Burkhard Lück.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated Dec. 22, 2014, 1:05 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-clang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port to .json from .desktop meta data file.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(98ac12487ca7219e36c5ef5ea2ef06f4e2bd089c)</span></li>
<li>clangsupport.cpp <span style="color: grey">(43f5306a2f994f207fcec90c76241ecbd1cdbcb5)</span></li>
<li>documentfinderhelpers.h <span style="color: grey">(05eaceb278195e192d2320d02e8fe87add69164d)</span></li>
<li>documentfinderhelpers.cpp <span style="color: grey">(2cdcbe690597648b864241dad74b6268c73cb94e)</span></li>
<li>kdevclangsupport.desktop.cmake <span style="color: grey">(ad186bd17f90f6557f380cbe268de6db58485ea4)</span></li>
<li>kdevclangsupport.json <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121629/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>