Review Request 121616: IDebugSession: reduce coupling between interface class and implementations

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121616/#review72391
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On Dec. 21, 2014, 11:11 p.m., Nicolai Hähnle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121616/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2014, 11:11 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Instead of having the derived class poke at IDebugSession member variables,
> we now use pure virtual methods to access IBreakpointController etc.
> This is in line with the design of other interfaces throughout kdevplatform.
> 
> Note that this change is both forward and backward source incompatible, i.e.
> debugger plugins must change simultaneously with this change or they will
> no longer compile. Since this change is fairly trivial, this seems acceptable.
> 
> 
> Diffs
> -----
> 
>   debugger/interfaces/idebugsession.cpp 193701d8b87de1d7712bb6b091e42ddee4cc0103 
>   debugger/interfaces/idebugsession.h 219c94865e76fc5e70247f6b96add6eb42391ff5 
> 
> Diff: https://git.reviewboard.kde.org/r/121616/diff/
> 
> 
> Testing
> -------
> 
> manual testing
> 
> 
> Thanks,
> 
> Nicolai Hähnle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141221/0d252405/attachment.html>