Review Request 121616: IDebugSession: reduce coupling between interface class and implementations

Nicolai Hähnle nhaehnle at
Sun Dec 21 23:11:39 UTC 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Dez. 21, 2014, 11:11 nachm.)

Review request for KDevelop.


Thank you for the feedback, I've addressed your comment.

Repository: kdevplatform


Instead of having the derived class poke at IDebugSession member variables,
we now use pure virtual methods to access IBreakpointController etc.
This is in line with the design of other interfaces throughout kdevplatform.

Note that this change is both forward and backward source incompatible, i.e.
debugger plugins must change simultaneously with this change or they will
no longer compile. Since this change is fairly trivial, this seems acceptable.

Diffs (updated)

  debugger/interfaces/idebugsession.cpp 193701d8b87de1d7712bb6b091e42ddee4cc0103 
  debugger/interfaces/idebugsession.h 219c94865e76fc5e70247f6b96add6eb42391ff5 



manual testing


Nicolai Hähnle

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list