Review Request 121586: Restore upload functionality to git.reviewboard.kde.org

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121586/#review72268
-----------------------------------------------------------


Looks good to me, not sure why, but the indentation is off in the .h files, maybe the editor you're using is putting tabs instead of spaces or vice versa.

That reminds me it's always tricky to find "show whitespace" option in kate/kdevelop whenever I try to tell a SoC or SoK student how to do that, maybe I should go make that option more obvious :)


plugins/git/gitplugin.h
<https://git.reviewboard.kde.org/r/121586/#comment50406>

    Indentation is off here.



plugins/git/gitplugin.h
<https://git.reviewboard.kde.org/r/121586/#comment50405>

    And here



vcs/widgets/vcsdiffpatchsources.h
<https://git.reviewboard.kde.org/r/121586/#comment50403>

    Indentation is off somehow.



vcs/widgets/vcsdiffpatchsources.h
<https://git.reviewboard.kde.org/r/121586/#comment50404>

    And here.


- Jeremy Whiting


On Dec. 18, 2014, 1:26 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121586/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2014, 1:26 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> A change was made on git.reviewboard.kde.org on December 13th a bit before 22h Europe/Paris time, ending support for p0 patch files. This broke the upload functionality in the current/stable version KDevelop's patchreview plugin.
> 
> The patch under review is a workaround (`*`) that restores this functionality by invoking the git helper process which generates the patchfiles with the correct arguments.
> 
> `*`) The real bug is in the reviewboard software, and should be addressed at that level. I work with a software distribution system that requires p0 patches, for which I created patches with KDevelop, something which will now require an additional step.
> 
> 
> Diffs
> -----
> 
>   plugins/git/gitplugin.h e930423 
>   plugins/git/gitplugin.cpp f38dc71 
>   plugins/patchreview/patchreview.cpp 18b63db 
>   plugins/reviewboard/reviewboardjobs.cpp 007a6e0 
>   plugins/reviewboard/reviewboardplugin.cpp 1dd3bcb 
>   vcs/vcsdiff.h 573ec1b 
>   vcs/vcsdiff.cpp 01eb73c 
>   vcs/widgets/vcsdiffpatchsources.h 6a2f934 
>   vcs/widgets/vcsdiffpatchsources.cpp c3e2dae 
> 
> Diff: https://git.reviewboard.kde.org/r/121586/diff/
> 
> 
> Testing
> -------
> 
> Under OS X 10.9; this RR has been created from a patched copy of KDevelop 4.7 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141218/8605f241/attachment-0001.html>