Review Request 121560: gdb: port SelectAddressDialog and SelectCoreDialog to QDialog

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121560/#review72138
-----------------------------------------------------------

Ship it!



debuggers/gdb/disassemblewidget.h
<https://git.reviewboard.kde.org/r/121560/#comment50320>

    Style: Remove 'get' as well then


- Kevin Funk


On Dec. 16, 2014, 5:06 p.m., Nicolai Hähnle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121560/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2014, 5:06 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Change those dialog classes to be derived from QDialog and use QDialogButtonBox.
> 
> At the same time, I changed Addr to Address in quite a few places.
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/CMakeLists.txt c477ffdc3a6ae94c889b4358ad37302ae74d2573 
>   debuggers/gdb/debuggerplugin.h 1243b623160a41e21aeed9e457267b3cd92412bb 
>   debuggers/gdb/debuggerplugin.cpp 256722931f9671241a544e560abaacf077678bf1 
>   debuggers/gdb/disassemblewidget.h 82c8d631857d73b3a76ee559d2ee3a13d994b56c 
>   debuggers/gdb/disassemblewidget.cpp 626c4ca9b8a5f4df8c89b24320e1471e6fd61a45 
>   debuggers/gdb/selectaddress.ui a155e4242f78d91e8956ce9d175142187f357926 
>   debuggers/gdb/selectcore.ui c98a64153c54e841477a10e5a696c9285a4cc416 
>   debuggers/gdb/selectcoredialog.h d05fdc19ab158bd8af164a5abc7e21c6ec70e722 
>   debuggers/gdb/selectcoredialog.cpp 453279af8b60d146d075afc2ed599d00159c378e 
>   debuggers/gdb/selectcoredialog.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121560/diff/
> 
> 
> Testing
> -------
> 
> Manual testing of the UI
> 
> 
> Thanks,
> 
> Nicolai Hähnle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141216/3d27f95a/attachment-0001.html>