<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121560/">https://git.reviewboard.kde.org/r/121560/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121560/diff/1/?file=333519#file333519line60" style="color: black; font-weight: bold; text-decoration: underline;">debuggers/gdb/disassemblewidget.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace KDevelop {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">60</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="nf">getAddr</span><span class="p">()</span> <span class="k">const</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">58</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">getAddr<span class="hl">ess</span></span><span class="p">()</span> <span class="k">const</span><span class="p"><span class="hl">;</span></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Style: Remove 'get' as well then</p></pre>
</div>
</div>
<br />
<p>- Kevin Funk</p>
<br />
<p>On December 16th, 2014, 5:06 p.m. UTC, Nicolai Hähnle wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Nicolai Hähnle.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2014, 5:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Change those dialog classes to be derived from QDialog and use QDialogButtonBox.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">At the same time, I changed Addr to Address in quite a few places.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Manual testing of the UI</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debuggers/gdb/CMakeLists.txt <span style="color: grey">(c477ffdc3a6ae94c889b4358ad37302ae74d2573)</span></li>
<li>debuggers/gdb/debuggerplugin.h <span style="color: grey">(1243b623160a41e21aeed9e457267b3cd92412bb)</span></li>
<li>debuggers/gdb/debuggerplugin.cpp <span style="color: grey">(256722931f9671241a544e560abaacf077678bf1)</span></li>
<li>debuggers/gdb/disassemblewidget.h <span style="color: grey">(82c8d631857d73b3a76ee559d2ee3a13d994b56c)</span></li>
<li>debuggers/gdb/disassemblewidget.cpp <span style="color: grey">(626c4ca9b8a5f4df8c89b24320e1471e6fd61a45)</span></li>
<li>debuggers/gdb/selectaddress.ui <span style="color: grey">(a155e4242f78d91e8956ce9d175142187f357926)</span></li>
<li>debuggers/gdb/selectcore.ui <span style="color: grey">(c98a64153c54e841477a10e5a696c9285a4cc416)</span></li>
<li>debuggers/gdb/selectcoredialog.h <span style="color: grey">(d05fdc19ab158bd8af164a5abc7e21c6ec70e722)</span></li>
<li>debuggers/gdb/selectcoredialog.cpp <span style="color: grey">(453279af8b60d146d075afc2ed599d00159c378e)</span></li>
<li>debuggers/gdb/selectcoredialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121560/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>