Review Request 121338: Fix bug on multi-line function-macro expansion, format preprocessed body for Cpp::NavigationWidget

Kevin Funk kfunk at kde.org
Sat Dec 6 17:25:46 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121338/#review71481
-----------------------------------------------------------


@Zhang: Can you please add tests for the fixes with regards to the defines handling in `rpp/`? Check `rpp/test/*` and `rpp/tests/main.cpp`.

- Kevin Funk


On Dec. 4, 2014, 11:57 a.m., Zhang HuiJie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121338/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 11:57 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Fix bug on multi-line function-macros expansion? format preprocessed body for Cpp::NavigationWidget
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cpplanguagesupport.cpp 79530e9 
>   languages/cpp/parser/rpp/pp-engine.cpp 8f6c8da 
>   languages/cpp/parser/rpp/pp-scanner.h 94fab52 
>   languages/cpp/parser/rpp/pp-scanner.cpp 28479d8 
> 
> Diff: https://git.reviewboard.kde.org/r/121338/diff/
> 
> 
> Testing
> -------
> 
> This patch work well on multi-line function-macros expansion, no test will fail because of this patch.
> 
> 
> Thanks,
> 
> Zhang HuiJie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141206/944ee64f/attachment.html>


More information about the KDevelop-devel mailing list