[kdevplatform/frameworks] /: Change semantics when deleting sessions a bit
kfunk at kde.org
Wed Aug 27 21:29:20 UTC 2014
On Wednesday 27 August 2014 22:33:02 Milian Wolff wrote:
> On Wednesday 27 August 2014 20:05:58 Kevin Funk wrote:
> > Git commit 073b69818c4d64c0ad46c7b6e0e63bfa00a4e477 by Kevin Funk.
> > Committed on 27/08/2014 at 20:01.
> > Pushed by kfunk into branch 'frameworks'.
> > Change semantics when deleting sessions a bit
> > Now we no longer defer the deletion of the ISession instance when
> > calling SessionController::deleteSession (I don't know why that was
> > needed anyway). If the to-be-deleted session was the active one, clear
> > the active session pointer. This keeps the SessionController in a sane
> > state even if the active session is deleted and the core stays alive.
> This might break stuff. Afaik the deferring is required since otherwise you
> delete data folders of temporary sessions but some things like e.g. the
> DUChain still tries to read/write from these files.
> Are you sure this all works? Do the language plugin unit tests still work?
Yep. Ran the test in KDevelop, too. Everything seems to be to fine.
I'll keep an eye on it.
Kevin Funk | kfunk at kde.org | http://kfunk.org
More information about the KDevelop-devel