Review Request 119938: Switch to QApplication in reviewboard test

[Dāvis Mosāns]

> On Aug. 26, 2014, 8:10 p.m., Dāvis Mosāns wrote:
> > plugins/reviewboard/tests/main.cpp, line 55
> > <https://git.reviewboard.kde.org/r/119938/diff/1/?file=307653#file307653line55>
> >
> >     _basedir_ also isn't used. What to do about these? I don't see point of them if they aren't used.
> 
> Aleix Pol Gonzalez wrote:
>     Uh... well then, remove it if it makes you happier.
>     The idea behind this is that we need to be able to test patch upload as well, right?

yeah, but it wasn't implemented and I dislike unfinished things :D so what about this?


- Dāvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119938/#review65290
-----------------------------------------------------------


On Aug. 26, 2014, 9:39 p.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119938/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2014, 9:39 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Switch to QApplication in reviewboard test
> 
> * KAboutData instead of K4AboutData
> * QCommandLineParser instead of KCmdLineArgs
> 
> 
> Diffs
> -----
> 
>   plugins/reviewboard/tests/main.cpp 7afbf9e6fd9d56f9018ca8f7da4e5126dc08dbaa 
>   plugins/reviewboard/reviewboardjobs.h 5282e167a436977407928555600383cea0c9c2ea 
>   plugins/reviewboard/reviewboardjobs.cpp 72e4c1340edddaeb9b56e7eb623f93dc1f8372f5 
> 
> Diff: https://git.reviewboard.kde.org/r/119938/diff/
> 
> 
> Testing
> -------
> 
> Compiles and seems to be working.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140826/a274afd7/attachment.html>