Review Request 119938: Switch to QApplication in reviewboard test

[Aleix Pol Gonzalez]

> On Aug. 26, 2014, 5:10 p.m., Dāvis Mosāns wrote:
> > plugins/reviewboard/tests/main.cpp, line 55
> > <https://git.reviewboard.kde.org/r/119938/diff/1/?file=307653#file307653line55>
> >
> >     _basedir_ also isn't used. What to do about these? I don't see point of them if they aren't used.

Uh... well then, remove it if it makes you happier.
The idea behind this is that we need to be able to test patch upload as well, right?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119938/#review65290
-----------------------------------------------------------


On Aug. 26, 2014, 2:39 a.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119938/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2014, 2:39 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Switch to QApplication in reviewboard test
> 
> * KAboutData instead of K4AboutData
> * QCommandLineParser instead of KCmdLineArgs
> 
> 
> Diffs
> -----
> 
>   plugins/reviewboard/tests/main.cpp 7afbf9e6fd9d56f9018ca8f7da4e5126dc08dbaa 
> 
> Diff: https://git.reviewboard.kde.org/r/119938/diff/
> 
> 
> Testing
> -------
> 
> Compiles and seems to be working.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140826/f26a5788/attachment-0001.html>