Review Request 119938: Switch to QApplication in reviewboard test

[Aleix Pol Gonzalez]

> On Aug. 26, 2014, 10:39 a.m., Aleix Pol Gonzalez wrote:
> > plugins/reviewboard/tests/main.cpp, line 25
> > <https://git.reviewboard.kde.org/r/119938/diff/1/?file=307653#file307653line25>
> >
> >     Don't add the namespace of the include.
> 
> Dāvis Mosāns wrote:
>     Why not? This way it's more clear from which library it comes, useful to known when linking, cleaning CMakeLists. Of course just my opinion.

You know they come from KF5, because they start with K*

Also you get errors faster when building with a missing dependency, because of the missing include directory.


> On Aug. 26, 2014, 10:39 a.m., Aleix Pol Gonzalez wrote:
> > plugins/reviewboard/tests/main.cpp, line 54
> > <https://git.reviewboard.kde.org/r/119938/diff/1/?file=307653#file307653line54>
> >
> >     You want QUrl::fromUserInput(..., AssumeLocal).
> >     
> >     Also the new Request should need the patch...
> 
> Dāvis Mosāns wrote:
>     Yeah, missed that, but fromUserInput takes only single arg.
>     
>     It wasn't used even before, ie. it's not used currently.

Uh right, it's new in 5.4. Then just leave the fromUserInput.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119938/#review65265
-----------------------------------------------------------


On Aug. 26, 2014, 2:39 a.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119938/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2014, 2:39 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Switch to QApplication in reviewboard test
> 
> * KAboutData instead of K4AboutData
> * QCommandLineParser instead of KCmdLineArgs
> 
> 
> Diffs
> -----
> 
>   plugins/reviewboard/tests/main.cpp 7afbf9e6fd9d56f9018ca8f7da4e5126dc08dbaa 
> 
> Diff: https://git.reviewboard.kde.org/r/119938/diff/
> 
> 
> Testing
> -------
> 
> Compiles and seems to be working.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140826/e405b151/attachment.html>