Review Request 119938: Switch to QApplication in reviewboard test

[Dāvis Mosāns]

> On Aug. 26, 2014, 1:39 p.m., Aleix Pol Gonzalez wrote:
> > plugins/reviewboard/tests/main.cpp, line 25
> > <https://git.reviewboard.kde.org/r/119938/diff/1/?file=307653#file307653line25>
> >
> >     Don't add the namespace of the include.

Why not? This way it's more clear from which library it comes, useful to known when linking, cleaning CMakeLists. Of course just my opinion.


> On Aug. 26, 2014, 1:39 p.m., Aleix Pol Gonzalez wrote:
> > plugins/reviewboard/tests/main.cpp, line 54
> > <https://git.reviewboard.kde.org/r/119938/diff/1/?file=307653#file307653line54>
> >
> >     You want QUrl::fromUserInput(..., AssumeLocal).
> >     
> >     Also the new Request should need the patch...

Yeah, missed that, but fromUserInput takes only single arg.

It wasn't used even before, ie. it's not used currently.


- Dāvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119938/#review65265
-----------------------------------------------------------


On Aug. 26, 2014, 5:39 a.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119938/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2014, 5:39 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Switch to QApplication in reviewboard test
> 
> * KAboutData instead of K4AboutData
> * QCommandLineParser instead of KCmdLineArgs
> 
> 
> Diffs
> -----
> 
>   plugins/reviewboard/tests/main.cpp 7afbf9e6fd9d56f9018ca8f7da4e5126dc08dbaa 
> 
> Diff: https://git.reviewboard.kde.org/r/119938/diff/
> 
> 
> Testing
> -------
> 
> Compiles and seems to be working.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140826/7a48b848/attachment.html>