Review Request 119918: Install a plugins to a versioned kdevplatform subdirectory

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119918/#review65119
-----------------------------------------------------------


see my comments here: https://git.reviewboard.kde.org/r/119919/

- Milian Wolff


On Aug. 24, 2014, 12:19 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119918/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2014, 12:19 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Install a plugins to a versioned kdevplatform subdirectory
> 
> 
> Diffs
> -----
> 
>   plugins/appwizard/CMakeLists.txt d0d61108725deaa81bfc4c8b63f34b0c4a35b07e 
>   plugins/appwizard/kdevappwizard.desktop.cmake 2b084658dd756c95b6b133c30ccc2df943be2a8c 
>   plugins/bazaar/CMakeLists.txt 73f7ece3baf75c68c59a94526dfe27904f1de658 
>   plugins/bazaar/kdevbazaar.desktop.cmake 439eabef7acf97fccaef060a33549a9533a30d0b 
>   plugins/classbrowser/CMakeLists.txt 9a19ceaa2f7cd352e2ff13276a7f2bace2e436a9 
>   plugins/classbrowser/kdevclassbrowser.desktop.cmake 97387c56ae0f7070314177c049ad6a389cc80c0b 
>   plugins/codeutils/CMakeLists.txt fb5373dd0bac920e48cdbf6f1715917d16835506 
>   plugins/codeutils/kdevcodeutils.desktop.cmake ff9ec2d415e3287ff41dcdf853fbeec3a054562b 
>   plugins/contextbrowser/CMakeLists.txt d7a9b1faf36955e1149fc6c5f16bf46d033d0e61 
>   plugins/contextbrowser/kdevcontextbrowser.desktop.cmake cc83a53316ac8eff65b7f684ea5ff75df605c401 
>   plugins/cvs/CMakeLists.txt f2ad96921db2dda33a2bcd2e4ede290a5c5eb57c 
>   plugins/cvs/kdevcvs.desktop.cmake 389162f13037723e779c623e793a98fba4eabe05 
>   plugins/dashboard/kdevprojectdashboard.desktop.cmake dd772af648f18a759bade7664eade0efa32bcf22 
>   plugins/dashboard/plasmoids/projectfileplasmoid/CMakeLists.txt 696900d402a247b3e4efbc32d87da1f012f2d01b 
>   plugins/documentswitcher/CMakeLists.txt 130cf03fda66012bcadfebd2f65784e2d0af04cd 
>   plugins/documentswitcher/kdevdocumentswitcher.desktop.cmake 5c940d70e185c31d7e5f4e6a9e5246ef8f5170d0 
>   plugins/documentview/CMakeLists.txt 714e4486aa3d33bf1fe69cda2275e68469baeb86 
>   plugins/documentview/kdevdocumentview.desktop.cmake 0b8817332f334ff3758fd7f4d622b3b8b7b16fad 
>   plugins/execute/CMakeLists.txt f445e9092676169a35b80efcdded798e1c517fc2 
>   plugins/execute/kdevexecute.desktop.cmake 555e5b8360a3edb497beb9179ec341010853f00e 
>   plugins/executescript/CMakeLists.txt 1d09cd897ed97513bb45732f3247337af5a7aadd 
>   plugins/executescript/kdevexecutescript.desktop.cmake 86ce008997b8339ac728eab22f31e88e89649166 
>   plugins/externalscript/CMakeLists.txt ebfaa7a61e9017ab79bc59db0b5fdff91e986721 
>   plugins/externalscript/kdevexternalscript.desktop.cmake f5c4cba65695e0321e1ec1747f595eeba5aaf6cc 
>   plugins/filemanager/CMakeLists.txt f45e656e1863d92a7ae570850671de25f6e610a9 
>   plugins/filemanager/kdevfilemanager.desktop.cmake afd3c06e818fba95a8ba523640848a295de86ac9 
>   plugins/filetemplates/CMakeLists.txt 52466da72965a104ff2277472a3777900c1fa0a5 
>   plugins/filetemplates/kdevfiletemplates.desktop.cmake b65d1a34d81d2e52c5b1d0445bac4abaadfdecbb 
>   plugins/genericprojectmanager/CMakeLists.txt 7d05d83982e7b29699a0f09a06c3ff3c9704f4c2 
>   plugins/genericprojectmanager/kdevgenericmanager.desktop.cmake 8a65799a28657ebd9e37277ac6b7edbb1852a4c8 
>   plugins/git/CMakeLists.txt 73e037cfd1795f58b61a7f5eeb4f55280cd8965e 
>   plugins/git/kdevgit.desktop.cmake b255ccdd050f1b46a5ec16a7a813cd62bb340a7b 
>   plugins/grepview/CMakeLists.txt 3dc2f2b2429f5a4cfe8dfcf0a586960b0e9f4637 
>   plugins/grepview/kdevgrepview.desktop.cmake 33543aa9a13abdee9b5c1b6f249d9592f4fae13a 
>   plugins/konsole/CMakeLists.txt cc9d6ed472ba896fa857e37d78b767348c2686c2 
>   plugins/konsole/kdevkonsoleview.desktop.cmake ff13a2c01cec9a4a0b7e6e9d14394724c0f67a37 
>   plugins/openwith/CMakeLists.txt 8d0a276ff93893769251245399170af84efcc7a3 
>   plugins/openwith/kdevopenwith.desktop.cmake ee7b91b60fca28e3b02c30706070219b98a58a21 
>   plugins/pastebin/CMakeLists.txt f6305553b029cd67b56ddaef1d0b06e905521d82 
>   plugins/pastebin/kdevpastebin.desktop.cmake 04f6320a5a6bc17f684dd1b7e9e3919f5a2ba038 
>   plugins/patchreview/CMakeLists.txt 132c74693240ed684e56f28fadb0a2bef7f0b8b8 
>   plugins/patchreview/kdevpatchreview.desktop.cmake a94731c05cd613219762653009c781ff00ecfa87 
>   plugins/problemreporter/CMakeLists.txt 4cc7fc978096182f8add31c11586a0802ff22cad 
>   plugins/problemreporter/kdevproblemreporter.desktop.cmake 6a322aa34a79b9f62ac7778e5366519b51f07b79 
>   plugins/projectfilter/CMakeLists.txt 007f889455eea15af438fb2dd2f53df94dd36c10 
>   plugins/projectfilter/kdevprojectfilter.desktop.cmake 173fd031a9cdb864f67fda33feeed375415802de 
>   plugins/projectmanagerview/CMakeLists.txt f717b12d660c3b460253051ecd53070101b74f0d 
>   plugins/projectmanagerview/kdevprojectmanagerview.desktop.cmake 238714354ac53f1f3451112b07d8972c961ed0d1 
>   plugins/quickopen/CMakeLists.txt bf883e79a96b6d13f62ca19819e61f9805dbbfde 
>   plugins/quickopen/kdevquickopen.desktop.cmake 667c2d90bf85fde48bf3e2321ba6049b21967b27 
>   plugins/reviewboard/CMakeLists.txt b54dbc090ef61842fe7c3afe5f3ccfca97ca6d9d 
>   plugins/reviewboard/kdevreviewboard.desktop.cmake c753e6ba8d395a9dffbf58c37b78cacffc5e8dc0 
>   plugins/snippet/CMakeLists.txt b280b802c2dba2fdff11d549114bf25a70596dc5 
>   plugins/snippet/kdevsnippet.desktop.cmake 68b167f1b3da466208a1fc9254904bcdf1170be5 
>   plugins/standardoutputview/CMakeLists.txt 878f4947b45062278087761d4ca487e58b079179 
>   plugins/standardoutputview/kdevstandardoutputview.desktop.cmake f02413e15dcfef5fdf518eebc38c0de30e090a56 
>   plugins/subversion/CMakeLists.txt de419ecda9d94a8dee895d2bfb318ba2d8cec56d 
>   plugins/subversion/kdevsubversion.desktop.cmake 473ace801289c753e65898a6d851b7fc147fa4db 
>   plugins/switchtobuddy/CMakeLists.txt b3e93ec40ca175e9a039a61102c850be27299c00 
>   plugins/switchtobuddy/kdevswitchtobuddy.desktop.cmake cb64e411899f4a892a399fb2cc7fb5af8b47656a 
>   plugins/templatemanager/CMakeLists.txt 543bedff7dfdbd05e3d60eaf79170573dfaa7103 
>   plugins/testview/CMakeLists.txt e4e21a90aaee4a54cf50f7fe1ed23ffb7c173aac 
>   plugins/testview/kdevtestview.desktop.cmake 313422b155f66552132dc1db1b124ec3b4608591 
>   plugins/vcschangesview/CMakeLists.txt 31463095cff6af29f8d377c1632523f15372c137 
>   plugins/vcschangesview/kdevvcschangesview.desktop.cmake 71343db8f2db8b5e4afd4fa4d19fcb39ab3d0fd4 
>   plugins/welcomepage/CMakeLists.txt ab97cf4ed7c0f3d312f2a855073aeae136a82202 
>   plugins/welcomepage/kdevwelcomepageplugin.desktop.cmake 195c625687f09a57bc940caac16bc768bf31d18f 
> 
> Diff: https://git.reviewboard.kde.org/r/119918/diff/
> 
> 
> Testing
> -------
> 
> Plugins still load.
> 
> This is the first towards using KPluginLoader::findPlugins() which will allow removing usage of kbuildsycoca
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140824/9c0c4329/attachment-0001.html>