<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119918/">https://git.reviewboard.kde.org/r/119918/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">see my comments here: https://git.reviewboard.kde.org/r/119919/</p></pre>
<br />
<p>- Milian Wolff</p>
<br />
<p>On August 24th, 2014, 12:19 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2014, 12:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Install a plugins to a versioned kdevplatform subdirectory</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Plugins still load.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is the first towards using KPluginLoader::findPlugins() which will allow removing usage of kbuildsycoca</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/appwizard/CMakeLists.txt <span style="color: grey">(d0d61108725deaa81bfc4c8b63f34b0c4a35b07e)</span></li>
<li>plugins/appwizard/kdevappwizard.desktop.cmake <span style="color: grey">(2b084658dd756c95b6b133c30ccc2df943be2a8c)</span></li>
<li>plugins/bazaar/CMakeLists.txt <span style="color: grey">(73f7ece3baf75c68c59a94526dfe27904f1de658)</span></li>
<li>plugins/bazaar/kdevbazaar.desktop.cmake <span style="color: grey">(439eabef7acf97fccaef060a33549a9533a30d0b)</span></li>
<li>plugins/classbrowser/CMakeLists.txt <span style="color: grey">(9a19ceaa2f7cd352e2ff13276a7f2bace2e436a9)</span></li>
<li>plugins/classbrowser/kdevclassbrowser.desktop.cmake <span style="color: grey">(97387c56ae0f7070314177c049ad6a389cc80c0b)</span></li>
<li>plugins/codeutils/CMakeLists.txt <span style="color: grey">(fb5373dd0bac920e48cdbf6f1715917d16835506)</span></li>
<li>plugins/codeutils/kdevcodeutils.desktop.cmake <span style="color: grey">(ff9ec2d415e3287ff41dcdf853fbeec3a054562b)</span></li>
<li>plugins/contextbrowser/CMakeLists.txt <span style="color: grey">(d7a9b1faf36955e1149fc6c5f16bf46d033d0e61)</span></li>
<li>plugins/contextbrowser/kdevcontextbrowser.desktop.cmake <span style="color: grey">(cc83a53316ac8eff65b7f684ea5ff75df605c401)</span></li>
<li>plugins/cvs/CMakeLists.txt <span style="color: grey">(f2ad96921db2dda33a2bcd2e4ede290a5c5eb57c)</span></li>
<li>plugins/cvs/kdevcvs.desktop.cmake <span style="color: grey">(389162f13037723e779c623e793a98fba4eabe05)</span></li>
<li>plugins/dashboard/kdevprojectdashboard.desktop.cmake <span style="color: grey">(dd772af648f18a759bade7664eade0efa32bcf22)</span></li>
<li>plugins/dashboard/plasmoids/projectfileplasmoid/CMakeLists.txt <span style="color: grey">(696900d402a247b3e4efbc32d87da1f012f2d01b)</span></li>
<li>plugins/documentswitcher/CMakeLists.txt <span style="color: grey">(130cf03fda66012bcadfebd2f65784e2d0af04cd)</span></li>
<li>plugins/documentswitcher/kdevdocumentswitcher.desktop.cmake <span style="color: grey">(5c940d70e185c31d7e5f4e6a9e5246ef8f5170d0)</span></li>
<li>plugins/documentview/CMakeLists.txt <span style="color: grey">(714e4486aa3d33bf1fe69cda2275e68469baeb86)</span></li>
<li>plugins/documentview/kdevdocumentview.desktop.cmake <span style="color: grey">(0b8817332f334ff3758fd7f4d622b3b8b7b16fad)</span></li>
<li>plugins/execute/CMakeLists.txt <span style="color: grey">(f445e9092676169a35b80efcdded798e1c517fc2)</span></li>
<li>plugins/execute/kdevexecute.desktop.cmake <span style="color: grey">(555e5b8360a3edb497beb9179ec341010853f00e)</span></li>
<li>plugins/executescript/CMakeLists.txt <span style="color: grey">(1d09cd897ed97513bb45732f3247337af5a7aadd)</span></li>
<li>plugins/executescript/kdevexecutescript.desktop.cmake <span style="color: grey">(86ce008997b8339ac728eab22f31e88e89649166)</span></li>
<li>plugins/externalscript/CMakeLists.txt <span style="color: grey">(ebfaa7a61e9017ab79bc59db0b5fdff91e986721)</span></li>
<li>plugins/externalscript/kdevexternalscript.desktop.cmake <span style="color: grey">(f5c4cba65695e0321e1ec1747f595eeba5aaf6cc)</span></li>
<li>plugins/filemanager/CMakeLists.txt <span style="color: grey">(f45e656e1863d92a7ae570850671de25f6e610a9)</span></li>
<li>plugins/filemanager/kdevfilemanager.desktop.cmake <span style="color: grey">(afd3c06e818fba95a8ba523640848a295de86ac9)</span></li>
<li>plugins/filetemplates/CMakeLists.txt <span style="color: grey">(52466da72965a104ff2277472a3777900c1fa0a5)</span></li>
<li>plugins/filetemplates/kdevfiletemplates.desktop.cmake <span style="color: grey">(b65d1a34d81d2e52c5b1d0445bac4abaadfdecbb)</span></li>
<li>plugins/genericprojectmanager/CMakeLists.txt <span style="color: grey">(7d05d83982e7b29699a0f09a06c3ff3c9704f4c2)</span></li>
<li>plugins/genericprojectmanager/kdevgenericmanager.desktop.cmake <span style="color: grey">(8a65799a28657ebd9e37277ac6b7edbb1852a4c8)</span></li>
<li>plugins/git/CMakeLists.txt <span style="color: grey">(73e037cfd1795f58b61a7f5eeb4f55280cd8965e)</span></li>
<li>plugins/git/kdevgit.desktop.cmake <span style="color: grey">(b255ccdd050f1b46a5ec16a7a813cd62bb340a7b)</span></li>
<li>plugins/grepview/CMakeLists.txt <span style="color: grey">(3dc2f2b2429f5a4cfe8dfcf0a586960b0e9f4637)</span></li>
<li>plugins/grepview/kdevgrepview.desktop.cmake <span style="color: grey">(33543aa9a13abdee9b5c1b6f249d9592f4fae13a)</span></li>
<li>plugins/konsole/CMakeLists.txt <span style="color: grey">(cc9d6ed472ba896fa857e37d78b767348c2686c2)</span></li>
<li>plugins/konsole/kdevkonsoleview.desktop.cmake <span style="color: grey">(ff13a2c01cec9a4a0b7e6e9d14394724c0f67a37)</span></li>
<li>plugins/openwith/CMakeLists.txt <span style="color: grey">(8d0a276ff93893769251245399170af84efcc7a3)</span></li>
<li>plugins/openwith/kdevopenwith.desktop.cmake <span style="color: grey">(ee7b91b60fca28e3b02c30706070219b98a58a21)</span></li>
<li>plugins/pastebin/CMakeLists.txt <span style="color: grey">(f6305553b029cd67b56ddaef1d0b06e905521d82)</span></li>
<li>plugins/pastebin/kdevpastebin.desktop.cmake <span style="color: grey">(04f6320a5a6bc17f684dd1b7e9e3919f5a2ba038)</span></li>
<li>plugins/patchreview/CMakeLists.txt <span style="color: grey">(132c74693240ed684e56f28fadb0a2bef7f0b8b8)</span></li>
<li>plugins/patchreview/kdevpatchreview.desktop.cmake <span style="color: grey">(a94731c05cd613219762653009c781ff00ecfa87)</span></li>
<li>plugins/problemreporter/CMakeLists.txt <span style="color: grey">(4cc7fc978096182f8add31c11586a0802ff22cad)</span></li>
<li>plugins/problemreporter/kdevproblemreporter.desktop.cmake <span style="color: grey">(6a322aa34a79b9f62ac7778e5366519b51f07b79)</span></li>
<li>plugins/projectfilter/CMakeLists.txt <span style="color: grey">(007f889455eea15af438fb2dd2f53df94dd36c10)</span></li>
<li>plugins/projectfilter/kdevprojectfilter.desktop.cmake <span style="color: grey">(173fd031a9cdb864f67fda33feeed375415802de)</span></li>
<li>plugins/projectmanagerview/CMakeLists.txt <span style="color: grey">(f717b12d660c3b460253051ecd53070101b74f0d)</span></li>
<li>plugins/projectmanagerview/kdevprojectmanagerview.desktop.cmake <span style="color: grey">(238714354ac53f1f3451112b07d8972c961ed0d1)</span></li>
<li>plugins/quickopen/CMakeLists.txt <span style="color: grey">(bf883e79a96b6d13f62ca19819e61f9805dbbfde)</span></li>
<li>plugins/quickopen/kdevquickopen.desktop.cmake <span style="color: grey">(667c2d90bf85fde48bf3e2321ba6049b21967b27)</span></li>
<li>plugins/reviewboard/CMakeLists.txt <span style="color: grey">(b54dbc090ef61842fe7c3afe5f3ccfca97ca6d9d)</span></li>
<li>plugins/reviewboard/kdevreviewboard.desktop.cmake <span style="color: grey">(c753e6ba8d395a9dffbf58c37b78cacffc5e8dc0)</span></li>
<li>plugins/snippet/CMakeLists.txt <span style="color: grey">(b280b802c2dba2fdff11d549114bf25a70596dc5)</span></li>
<li>plugins/snippet/kdevsnippet.desktop.cmake <span style="color: grey">(68b167f1b3da466208a1fc9254904bcdf1170be5)</span></li>
<li>plugins/standardoutputview/CMakeLists.txt <span style="color: grey">(878f4947b45062278087761d4ca487e58b079179)</span></li>
<li>plugins/standardoutputview/kdevstandardoutputview.desktop.cmake <span style="color: grey">(f02413e15dcfef5fdf518eebc38c0de30e090a56)</span></li>
<li>plugins/subversion/CMakeLists.txt <span style="color: grey">(de419ecda9d94a8dee895d2bfb318ba2d8cec56d)</span></li>
<li>plugins/subversion/kdevsubversion.desktop.cmake <span style="color: grey">(473ace801289c753e65898a6d851b7fc147fa4db)</span></li>
<li>plugins/switchtobuddy/CMakeLists.txt <span style="color: grey">(b3e93ec40ca175e9a039a61102c850be27299c00)</span></li>
<li>plugins/switchtobuddy/kdevswitchtobuddy.desktop.cmake <span style="color: grey">(cb64e411899f4a892a399fb2cc7fb5af8b47656a)</span></li>
<li>plugins/templatemanager/CMakeLists.txt <span style="color: grey">(543bedff7dfdbd05e3d60eaf79170573dfaa7103)</span></li>
<li>plugins/testview/CMakeLists.txt <span style="color: grey">(e4e21a90aaee4a54cf50f7fe1ed23ffb7c173aac)</span></li>
<li>plugins/testview/kdevtestview.desktop.cmake <span style="color: grey">(313422b155f66552132dc1db1b124ec3b4608591)</span></li>
<li>plugins/vcschangesview/CMakeLists.txt <span style="color: grey">(31463095cff6af29f8d377c1632523f15372c137)</span></li>
<li>plugins/vcschangesview/kdevvcschangesview.desktop.cmake <span style="color: grey">(71343db8f2db8b5e4afd4fa4d19fcb39ab3d0fd4)</span></li>
<li>plugins/welcomepage/CMakeLists.txt <span style="color: grey">(ab97cf4ed7c0f3d312f2a855073aeae136a82202)</span></li>
<li>plugins/welcomepage/kdevwelcomepageplugin.desktop.cmake <span style="color: grey">(195c625687f09a57bc940caac16bc768bf31d18f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119918/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>