Review Request 119898: Fix sizeHint for IdealToolButton

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119898/#review65033
-----------------------------------------------------------


Could you show us some screenshots? Before/After? Where did you see issues with the current versions?

- Kevin Funk


On Aug. 22, 2014, 9:32 a.m., Hugo Pereira Da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119898/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2014, 9:32 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> As title says:
> use sizeFromContents from style rather than fixed spacing and margin, to get the correct size hint. This is similar to what is done in QToolButton and fixes truncated text for styles that add extra spacing (consistently with sizeFromContents) when rendering toolbuttons (this is the case for breeze)
> 
> Note: this also removes a "FIXME" comment
> 
> 
> Diffs
> -----
> 
>   sublime/idealtoolbutton.cpp abecdca 
> 
> Diff: https://git.reviewboard.kde.org/r/119898/diff/
> 
> 
> Testing
> -------
> 
> Tested with oxygen, breeze and fusion.
> 
> 
> Thanks,
> 
> Hugo Pereira Da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140822/84b63c28/attachment.html>