Review Request 119898: Fix sizeHint for IdealToolButton
Hugo Pereira Da Costa
hugo.pereira at free.fr
Fri Aug 22 09:32:09 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119898/
-----------------------------------------------------------
Review request for KDevelop.
Repository: kdevplatform
Description
-------
As title says:
use sizeFromContents from style rather than fixed spacing and margin, to get the correct size hint. This is similar to what is done in QToolButton and fixes truncated text for styles that add extra spacing (consistently with sizeFromContents) when rendering toolbuttons (this is the case for breeze)
Note: this also removes a "FIXME" comment
Diffs
-----
sublime/idealtoolbutton.cpp abecdca
Diff: https://git.reviewboard.kde.org/r/119898/diff/
Testing
-------
Tested with oxygen, breeze and fusion.
Thanks,
Hugo Pereira Da Costa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140822/58a812f1/attachment.html>
More information about the KDevelop-devel
mailing list