Review Request 117844: Add a getQMLAttribute utility function

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117844/#review56761
-----------------------------------------------------------

Ship it!


Sounds good, please push.

It'd be nice if in future reviews you could separate moving code around from changing code, that makes it hard to see what changes ;)

Thanks!

- Sven Brauch


On April 28, 2014, 3:07 p.m., Denis Steckelmacher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117844/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 3:07 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-qmljs
> 
> 
> Description
> -------
> 
> This patch moves the static findIdentifier() function that was used by DeclarationBuilder to find the identifier of a QML object to Utils, and adds a new parameter to this function allowing the caller to specify what attribute it needs ("id" for the identifier, but "name" or "prototype" will be used in plugin.qmltypes files). Moreover, the function not only recognizes identifiers (id: foo), but also string literals (name: "QAbstractItemModel").
> 
> 
> Diffs
> -----
> 
>   duchain/declarationbuilder.cpp 7b70c2c 
>   duchain/helper.h 6112d7d 
>   duchain/helper.cpp 25e8586 
> 
> Diff: https://git.reviewboard.kde.org/r/117844/diff/
> 
> 
> Testing
> -------
> 
> The whole testsuite continues to pass.
> 
> 
> Thanks,
> 
> Denis Steckelmacher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140428/a2ae9c7b/attachment.html>