Review Request 117844: Add a getQMLAttribute utility function

Denis Steckelmacher steckdenis at
Mon Apr 28 15:07:25 UTC 2014

This is an automatically generated e-mail. To reply, visit:

Review request for KDevelop.

Repository: kdev-qmljs


This patch moves the static findIdentifier() function that was used by DeclarationBuilder to find the identifier of a QML object to Utils, and adds a new parameter to this function allowing the caller to specify what attribute it needs ("id" for the identifier, but "name" or "prototype" will be used in plugin.qmltypes files). Moreover, the function not only recognizes identifiers (id: foo), but also string literals (name: "QAbstractItemModel").


  duchain/declarationbuilder.cpp 7b70c2c 
  duchain/helper.h 6112d7d 
  duchain/helper.cpp 25e8586 



The whole testsuite continues to pass.


Denis Steckelmacher

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list