Review Request 117014: KDevelop - search and load qch files on startup in an specified directory

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117014/#review56226
-----------------------------------------------------------

Ship it!


looks good, except for some minor formatting issues. I'll fix that locally and commit it for you.

thanks!


documentation/qthelp/qthelp_config_shared.h
<https://git.reviewboard.kde.org/r/117014/#comment39303>

    remove space in front of the & (also below and in the .cpp)



documentation/qthelp/qthelpconfig.cpp
<https://git.reviewboard.kde.org/r/117014/#comment39304>

    here and below: excessive newline



documentation/qthelp/qthelpplugin.h
<https://git.reviewboard.kde.org/r/117014/#comment39305>

    same issue with the spaces in front of &


- Milian Wolff


On March 24, 2014, 6:29 a.m., Bastian Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117014/
> -----------------------------------------------------------
> 
> (Updated March 24, 2014, 6:29 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 332404
>     http://bugs.kde.org/show_bug.cgi?id=332404
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Quick implementation for searching qch files in an specified directory. The directory can be specified in the QTHelp Dialog. KDevelop search the qch files on startup. The imported qch files are NOT added to the manual documentation list. The default icon is the qtlogo an the name is the basename of the file.
> 
> 
> Diffs
> -----
> 
>   documentation/qthelp/qthelpconfig.h 8c97afb 
>   documentation/qthelp/qthelpconfig.cpp e353f7d 
>   documentation/qthelp/qthelp_config_shared.cpp 8aafef5 
>   documentation/qthelp/qthelp_config_shared.h b4d42e4 
>   documentation/qthelp/qthelpconfig.ui 158b267 
>   documentation/qthelp/qthelpplugin.h 7ae83f2 
>   documentation/qthelp/qthelpplugin.cpp f830c6a 
> 
> Diff: https://git.reviewboard.kde.org/r/117014/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bastian Schmidt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140422/89193b1c/attachment.html>