Review Request 117656: Improved KDevelop teplates
Simon Wächter
waechter.simon at gmail.com
Tue Apr 22 10:40:00 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117656/
-----------------------------------------------------------
(Updated April 22, 2014, 10:39 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDevelop and Sven Brauch.
Repository: kdevelop
Description
-------
This patch improves the template provided by KDevelop:
- Variable naming
- Indentation
- Included files
- CMake files (Version, install commands and readability)
If there are other things to improve in the templates, please let it know me.
Diffs
-----
app_templates/cpp/CMake/cmake_plaincpp/CMakeLists.txt f649c5f
app_templates/cpp/CMake/cmake_qt4core/%{APPNAME}.h e7c7b49
app_templates/cpp/CMake/cmake_qt4core/CMakeLists.txt 4e91282
app_templates/cpp/CMake/cmake_qt4core/main.cpp 426830e
app_templates/cpp/CMake/cmake_qt4core_qtest/%{APPNAME}.h 2d49681
app_templates/cpp/CMake/cmake_qt4core_qtest/CMakeLists.txt 5e83972
app_templates/cpp/CMake/cmake_qt4core_qtest/main.cpp 426830e
app_templates/cpp/CMake/cmake_qt4core_qtest/tests/%{APPNAME}Test.h 02759ec
app_templates/cpp/CMake/cmake_qt4core_qtest/tests/%{APPNAME}Test.cpp 632a3f8
app_templates/cpp/CMake/cmake_qt4core_qtest/tests/CMakeLists.txt a07e256
app_templates/cpp/CMake/cmake_qt4gui/%{APPNAME}.h 3c50df5
app_templates/cpp/CMake/cmake_qt4gui/%{APPNAME}.cpp a1ded84
app_templates/cpp/CMake/cmake_qt4gui/CMakeLists.txt c38bdde
app_templates/cpp/CMake/cmake_qt4gui/main.cpp 67c6ca7
Diff: https://git.reviewboard.kde.org/r/117656/diff/
Testing
-------
Templates were succesfully tested with gcc 4.8.2 and clang 3.3 under Debian
Thanks,
Simon Wächter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140422/e0810552/attachment.html>
More information about the KDevelop-devel
mailing list