Review Request 117515: Deduce the type of common binary expressions

Denis Steckelmacher steckdenis at yahoo.fr
Sat Apr 12 17:34:26 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117515/
-----------------------------------------------------------

(Updated April 12, 2014, 5:34 p.m.)


Review request for KDevelop.


Changes
-------

There are now tests for boolean types (== and &&) and integer types (<<).


Repository: kdev-qmljs


Description
-------

Several binary expressions have always the same type, independently of the type of the operands. Such operations either always return a boolean (==, <, >, >=, in, &&, ||, etc) or always an integer (<<, >>, &, | and ^). This patch recognizes these expressions in ExpressionVisitor.


Diffs (updated)
-----

  duchain/expressionvisitor.h 5c065ad 
  duchain/expressionvisitor.cpp 17bd266 
  tests/files/helloworld.js 3696b2c 

Diff: https://git.reviewboard.kde.org/r/117515/diff/


Testing
-------

This patch adds a test ensuring that "a == b" is recognized as having a boolean type. 


Thanks,

Denis Steckelmacher

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140412/46d2647a/attachment.html>


More information about the KDevelop-devel mailing list