Review Request 117515: Deduce the type of common binary expressions

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117515/#review55524
-----------------------------------------------------------

Ship it!


Looks good, except that -- as I mentioned last time -- IntegralType won't work for at least int (because it has methods etc.). But that can be changed later. Maybe one or two more tests wouldn't hurt either? ;)

- Sven Brauch


On April 12, 2014, 5:20 p.m., Denis Steckelmacher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117515/
> -----------------------------------------------------------
> 
> (Updated April 12, 2014, 5:20 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-qmljs
> 
> 
> Description
> -------
> 
> Several binary expressions have always the same type, independently of the type of the operands. Such operations either always return a boolean (==, <, >, >=, in, &&, ||, etc) or always an integer (<<, >>, &, | and ^). This patch recognizes these expressions in ExpressionVisitor.
> 
> 
> Diffs
> -----
> 
>   duchain/expressionvisitor.h 5c065ad 
>   duchain/expressionvisitor.cpp 17bd266 
>   tests/files/helloworld.js 3696b2c 
> 
> Diff: https://git.reviewboard.kde.org/r/117515/diff/
> 
> 
> Testing
> -------
> 
> This patch adds a test ensuring that "a == b" is recognized as having a boolean type. 
> 
> 
> Thanks,
> 
> Denis Steckelmacher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140412/91b178f5/attachment.html>