Review Request 117407: Add a project name validation in the project creation dialog

[Simon Wächter]

> On April 7, 2014, 1:55 a.m., Aleix Pol Gonzalez wrote:
> > plugins/appwizard/projectselectionpage.cpp, line 195
> > <https://git.reviewboard.kde.org/r/117407/diff/2/?file=263225#file263225line195>
> >
> >     How did you come up with this restriction?
> >     
> >     Why people can't put accents to the project name? Or even dashes?
> >     
> >     Definitely a no-go.

The restriction was added to avoid a project generation with invalid class names (C++ and afaik Python). Create a new project from a template and use some strange project name, it will result in a *broken* project.

Maybe it's a better idea just to show a warning (--> Project name might lead to invalid class names) and let the user do the job ?


- Simon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117407/#review55099
-----------------------------------------------------------


On April 6, 2014, 9:06 p.m., Simon Wächter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117407/
> -----------------------------------------------------------
> 
> (Updated April 6, 2014, 9:06 p.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This patch adds a regex validation for the project name in the project creation dialog. The project name has to start with a/A-z/Z and can contain a/A-z/Z, 0-9 and the _ character.
> 
> The idea of this patch is to make an invalid class name in a new project impossible, for example "42fooclass" or "_barclass".
> 
> 
> Diffs
> -----
> 
>   plugins/appwizard/projectselectionpage.cpp 6270869 
> 
> Diff: https://git.reviewboard.kde.org/r/117407/diff/
> 
> 
> Testing
> -------
> 
> Tested with several different project strings
> 
> 
> Thanks,
> 
> Simon Wächter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140407/fff3f571/attachment.html>