Review Request 117407: Add a project name validation in the project creation dialog
Aleix Pol Gonzalez
aleixpol at kde.org
Sun Apr 6 23:55:38 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117407/#review55099
-----------------------------------------------------------
plugins/appwizard/projectselectionpage.cpp
<https://git.reviewboard.kde.org/r/117407/#comment38419>
How did you come up with this restriction?
Why people can't put accents to the project name? Or even dashes?
Definitely a no-go.
- Aleix Pol Gonzalez
On April 6, 2014, 7:06 p.m., Simon Wächter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117407/
> -----------------------------------------------------------
>
> (Updated April 6, 2014, 7:06 p.m.)
>
>
> Review request for KDevelop and Sven Brauch.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> This patch adds a regex validation for the project name in the project creation dialog. The project name has to start with a/A-z/Z and can contain a/A-z/Z, 0-9 and the _ character.
>
> The idea of this patch is to make an invalid class name in a new project impossible, for example "42fooclass" or "_barclass".
>
>
> Diffs
> -----
>
> plugins/appwizard/projectselectionpage.cpp 6270869
>
> Diff: https://git.reviewboard.kde.org/r/117407/diff/
>
>
> Testing
> -------
>
> Tested with several different project strings
>
>
> Thanks,
>
> Simon Wächter
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140406/d5cdd80e/attachment.html>
More information about the KDevelop-devel
mailing list