Review Request 117098: Add #include-suggestion to kdev-clang

[Jørgen Kvalsvik]

> On April 5, 2014, 10:25 p.m., Kevin Funk wrote:
> > duchain/missinginclude.cpp, line 203
> > <https://git.reviewboard.kde.org/r/117098/diff/2/?file=262246#file262246line203>
> >
> >     Shouldn't that be used for 'scanIncludePaths' and friends, too?
> >     
> >     Also: rename to "isBlacklisted"

It is - a slight oversight on my part.


> On April 5, 2014, 10:25 p.m., Kevin Funk wrote:
> > duchain/missinginclude.cpp, line 242
> > <https://git.reviewboard.kde.org/r/117098/diff/2/?file=262246#file262246line242>
> >
> >     'ptr' is a bit too random. Please name that properly (e.g. 'file')


> On April 5, 2014, 10:25 p.m., Kevin Funk wrote:
> > duchain/missinginclude.cpp, line 399
> > <https://git.reviewboard.kde.org/r/117098/diff/2/?file=262246#file262246line399>
> >
> >     Typo: 'ducands'

Renamed to candidates.


- Jørgen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117098/#review55041
-----------------------------------------------------------


On April 1, 2014, 7:46 p.m., Jørgen Kvalsvik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117098/
> -----------------------------------------------------------
> 
> (Updated April 1, 2014, 7:46 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Add #include-suggestion features to kdev-clang
> 
> 
> Diffs
> -----
> 
>   duchain/CMakeLists.txt d21011a 
>   duchain/missinginclude.h PRE-CREATION 
>   duchain/missinginclude.cpp PRE-CREATION 
>   duchain/parsesession.cpp eee9fb1 
> 
> Diff: https://git.reviewboard.kde.org/r/117098/diff/
> 
> 
> Testing
> -------
> 
> The following errors have been tested, all in an empty project with no CMake file or configuration.
> 
> std::vector< int > vect; -> suggests <vector> + forward decl.
> QState state; -> suggests <qt4/QtCore/QState> + forward decl.
> std::vector< unknown > vect; -> suggests forward declarations.
> 
> 
> Thanks,
> 
> Jørgen Kvalsvik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140406/2eac07c3/attachment.html>