Review Request 117098: Add #include-suggestion to kdev-clang

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117098/#review55041
-----------------------------------------------------------


Use my new ClangUtils::defaultIncludeDirectories().

Rest looks good.


duchain/missinginclude.cpp
<https://git.reviewboard.kde.org/r/117098/#comment38393>

    Shouldn't that be used for 'scanIncludePaths' and friends, too?
    
    Also: rename to "isBlacklisted"



duchain/missinginclude.cpp
<https://git.reviewboard.kde.org/r/117098/#comment38386>

    'url' -> 'filePath'?



duchain/missinginclude.cpp
<https://git.reviewboard.kde.org/r/117098/#comment38385>

    'ptr' is a bit too random. Please name that properly (e.g. 'file')



duchain/missinginclude.cpp
<https://git.reviewboard.kde.org/r/117098/#comment38392>

    'file' -> 'filePath'



duchain/missinginclude.cpp
<https://git.reviewboard.kde.org/r/117098/#comment38387>

    Please factor this out in a separate commit, it's easy enough.



duchain/missinginclude.cpp
<https://git.reviewboard.kde.org/r/117098/#comment38388>

    Typo: 'ducands'



duchain/missinginclude.cpp
<https://git.reviewboard.kde.org/r/117098/#comment38394>

    Use a const-variable in unnamed ns for that, e.g. "MaxNumberOfSuggestions"


- Kevin Funk


On April 1, 2014, 7:46 p.m., Jørgen Kvalsvik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117098/
> -----------------------------------------------------------
> 
> (Updated April 1, 2014, 7:46 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Add #include-suggestion features to kdev-clang
> 
> 
> Diffs
> -----
> 
>   duchain/CMakeLists.txt d21011a 
>   duchain/missinginclude.h PRE-CREATION 
>   duchain/missinginclude.cpp PRE-CREATION 
>   duchain/parsesession.cpp eee9fb1 
> 
> Diff: https://git.reviewboard.kde.org/r/117098/diff/
> 
> 
> Testing
> -------
> 
> The following errors have been tested, all in an empty project with no CMake file or configuration.
> 
> std::vector< int > vect; -> suggests <vector> + forward decl.
> QState state; -> suggests <qt4/QtCore/QState> + forward decl.
> std::vector< unknown > vect; -> suggests forward declarations.
> 
> 
> Thanks,
> 
> Jørgen Kvalsvik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140405/27b1bbbf/attachment.html>