[kdevplatform] shell/workingsets: Rename the "Close" working set button to "Stash"

Sven Brauch svenbrauch at googlemail.com
Tue Apr 1 11:12:28 UTC 2014


On Tuesday 01 April 2014 13:06:03 you wrote:
> Won't that make people think that it's integrated with git and that it does
> something?
Mmh, didn't think about that. Do you think it will?
There was a user in #kdevelop-devel who was thinking clicking that would 
destroy the set -- which is not very far-fetched imo.
Maybe we could instead have a tooltip?

Greetings!


> On Tue, Apr 1, 2014 at 10:46 AM, Sven Brauch 
<svenbrauch at googlemail.com>wrote:
> > Git commit 5afc623a2b984c252f1cb4b8478542d0b61e85e1 by Sven Brauch.
> > Committed on 01/04/2014 at 08:45.
> > Pushed by brauch into branch 'master'.
> > 
> > Rename the "Close" working set button to "Stash"
> > 
> > This should make it more clear what it does, esp. that it does not discard
> > the set.
> > 
> > M  +1    -1    shell/workingsets/workingsettooltipwidget.cpp
> > 
> > 
> > http://commits.kde.org/kdevplatform/5afc623a2b984c252f1cb4b8478542d0b61e85
> > e1
> > 
> > diff --git a/shell/workingsets/workingsettooltipwidget.cpp
> > b/shell/workingsets/workingsettooltipwidget.cpp
> > index 3d54125..c9f2492 100644
> > --- a/shell/workingsets/workingsettooltipwidget.cpp
> > +++ b/shell/workingsets/workingsettooltipwidget.cpp
> > @@ -313,7 +313,7 @@ void WorkingSetToolTipWidget::updateFileButtons()
> > 
> >          connect(m_openButton, SIGNAL(clicked(bool)), m_setButton,
> > 
> > SLOT(closeSet()));
> > 
> >          connect(m_openButton, SIGNAL(clicked(bool)), this,
> > 
> > SIGNAL(shouldClose()));
> > 
> >          m_openButton->setIcon(KIcon("project-development-close"));
> > 
> > -        m_openButton->setText(i18n("Close"));
> > +        m_openButton->setText(i18n("Stash"));
> > 
> >      }else{
> >      
> >          disconnect(m_openButton, SIGNAL(clicked(bool)), m_setButton,
> > 
> > SLOT(closeSet()));
> > 
> >          connect(m_openButton, SIGNAL(clicked(bool)), m_setButton,
> > 
> > SLOT(loadSet()));



More information about the KDevelop-devel mailing list