Review Request 117213: Fix for importing a CMake project with missing directories

[Pavel Petrushkov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117213/
-----------------------------------------------------------

(Updated April 1, 2014, 11:04 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop and Aleix Pol Gonzalez.


Bugs: 332728
    http://bugs.kde.org/show_bug.cgi?id=332728


Repository: kdevelop


Description
-------

Importing project with nonexisting, but added in add_subdirectory() directories no longer causes KDevelop to load forever. Problem was in creating CMakeCommitChangesJob before checking if directory actually exists.


Diffs
-----

  projectmanagers/cmake/cmakeimportjob.cpp 6b0143f 

Diff: https://git.reviewboard.kde.org/r/117213/diff/


Testing
-------

Successfully loaded project mentioned in bug report, other projects also seem to load correctly.


Thanks,

Pavel Petrushkov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140401/cf86c77c/attachment.html>