Review Request 112916: Add support for traits to ClassDeclarationData

Milian Wolff mail at milianw.de
Wed Sep 25 20:10:32 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112916/#review40798
-----------------------------------------------------------

Ship it!


Considering that this doesn't come with any penalty to other languages I'm all for merging this as-is. What we have already is often cpp specific awe should not make it harder for other languages for simple things such as this 

- Milian Wolff


On Sept. 24, 2013, 1:29 p.m., Heinz Wiesinger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112916/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2013, 1:29 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Add support for traits to ClassDeclarationData.
> 
> 
> Diffs
> -----
> 
>   language/duchain/classdeclaration.h 6575763042de3fc7077ad723a1c3bc8f074b0696 
>   language/duchain/classdeclaration.cpp 0670209450038e0170a7921326bb57b7f9abf90d 
>   language/duchain/navigation/abstractdeclarationnavigationcontext.cpp 6b3c26097ba8c3de82a654825ae365cb2d4cd16a 
> 
> Diff: http://git.reviewboard.kde.org/r/112916/diff/
> 
> 
> Testing
> -------
> 
> "make test", showed no new regressions
> 
> 
> Thanks,
> 
> Heinz Wiesinger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130925/56d96c4a/attachment-0001.html>


More information about the KDevelop-devel mailing list