Review Request 112916: Add support for traits to ClassDeclarationData

[Miquel Sabaté]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112916/#review40777
-----------------------------------------------------------


Hi there,

I'm actually against this patch. Instead of adding a new ClassType value, why don't you just use a value that won't be used by the PHP plugin like ClassDeclarationData::Struct ? This way, we won't we adding a new value for a structure that is quite PHP-specific (even though some other languages like Scala also have traits, but I think it's a different concept in there :/). So my point is to simply re-use an already existent value like Struct.

- Miquel Sabaté


On Sept. 24, 2013, 1:29 p.m., Heinz Wiesinger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112916/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2013, 1:29 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Add support for traits to ClassDeclarationData.
> 
> 
> Diffs
> -----
> 
>   language/duchain/classdeclaration.h 6575763042de3fc7077ad723a1c3bc8f074b0696 
>   language/duchain/classdeclaration.cpp 0670209450038e0170a7921326bb57b7f9abf90d 
>   language/duchain/navigation/abstractdeclarationnavigationcontext.cpp 6b3c26097ba8c3de82a654825ae365cb2d4cd16a 
> 
> Diff: http://git.reviewboard.kde.org/r/112916/diff/
> 
> 
> Testing
> -------
> 
> "make test", showed no new regressions
> 
> 
> Thanks,
> 
> Heinz Wiesinger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130925/fef65367/attachment.html>