Review Request 112078: Creates a new file when trying to open a nonexistent file
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Sep 23 11:18:21 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112078/#review40534
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Sept. 21, 2013, 9:51 p.m., lycantrophe li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112078/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2013, 9:51 p.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> Removes the check if a file exists (KIO::NetAccess::exists()) so that the following routines will create the file instead of just attempting to open it.
>
>
> This addresses bug 322678.
> http://bugs.kde.org/show_bug.cgi?id=322678
>
>
> Diffs
> -----
>
> shell/documentcontroller.cpp 4d34629
>
> Diff: http://git.reviewboard.kde.org/r/112078/diff/
>
>
> Testing
> -------
>
> Tested both opening and creating files through the open file dialogue. Confirmed that creating files with File->New works as well.
>
>
> File Attachments
> ----------------
>
> open-create-file.patch
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/21/open-create-file.patch
>
>
> Thanks,
>
> lycantrophe li
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130923/1fc5e460/attachment.html>
More information about the KDevelop-devel
mailing list