Review Request 112078: Creates a new file when trying to open a nonexistent file

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112078/#review40433
-----------------------------------------------------------

Ship it!


Good change, I like it. Aleix, objections?

Can you please change the kDebug() to something matching better (e.g. "invalid URL")?
We might also consider showing a message box (KMessageBox::error), to make it clear why nothing happend (right now it just does nothing)... but just if you want to do that, it doesn't need to be there.

- Sven Brauch


On Sept. 21, 2013, 9:51 p.m., lycantrophe li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112078/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2013, 9:51 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Removes the check if a file exists (KIO::NetAccess::exists()) so that the following routines will create the file instead of just attempting to open it.
> 
> 
> This addresses bug 322678.
>     http://bugs.kde.org/show_bug.cgi?id=322678
> 
> 
> Diffs
> -----
> 
>   shell/documentcontroller.cpp 4d34629 
> 
> Diff: http://git.reviewboard.kde.org/r/112078/diff/
> 
> 
> Testing
> -------
> 
> Tested both opening and creating files through the open file dialogue. Confirmed that creating files with File->New works as well.
> 
> 
> File Attachments
> ----------------
> 
> open-create-file.patch
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/21/open-create-file.patch
> 
> 
> Thanks,
> 
> lycantrophe li
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130921/82baeddb/attachment.html>