Review Request 112590: Fix todo marker words and detailed completion settings not persistent across application restart.

Commit Hook null at kde.org
Sun Sep 15 05:59:21 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112590/#review40044
-----------------------------------------------------------


This review has been submitted with commit e5b18d8f5ae5083b5d7bb1276320a90c0d43ad44 by Vlas Puhov to branch master.

- Commit Hook


On Sept. 11, 2013, 4:01 p.m., Vlas Puhov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112590/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2013, 4:01 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> CCPreferences class is written with use of KCModule, so all setting can be saved/loaded automatically. For that widget's names should start with kcfg_ prefix, but neither todoMarkerWords nor completionDetail had one, so this feature didn't work.
> 
> 
> This addresses bug 324510.
>     http://bugs.kde.org/show_bug.cgi?id=324510
> 
> 
> Diffs
> -----
> 
>   shell/settings/ccsettings.ui 64d24e2 
>   shell/settings/ccpreferences.h 4ecf623 
>   shell/settings/ccpreferences.cpp 0347fc6 
>   shell/settings/ccconfig.kcfg 1bc89b1 
>   shell/completionsettings.h b3f28ce 
>   shell/completionsettings.cpp 6b6adf6 
>   interfaces/icompletionsettings.h eb615ae 
> 
> Diff: http://git.reviewboard.kde.org/r/112590/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vlas Puhov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130915/380ee816/attachment.html>


More information about the KDevelop-devel mailing list