Review Request 112590: Fix todo marker words and detailed completion settings not persistent across application restart.

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112590/#review39991
-----------------------------------------------------------



shell/completionsettings.cpp
<http://git.reviewboard.kde.org/r/112590/#comment29519>

    I'd qualified LAST_LEVEL here with the class name where its defined so its clear where this comes from.



shell/settings/ccpreferences.cpp
<http://git.reviewboard.kde.org/r/112590/#comment29518>

    I think the function can now be dropped completely, it serves no further purpose other than calling the base class version.


Other than those two minor things the patch looks great now.

- Andreas Pakulat


On Sept. 11, 2013, 4:01 p.m., Vlas Puhov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112590/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2013, 4:01 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> CCPreferences class is written with use of KCModule, so all setting can be saved/loaded automatically. For that widget's names should start with kcfg_ prefix, but neither todoMarkerWords nor completionDetail had one, so this feature didn't work.
> 
> 
> This addresses bug 324510.
>     http://bugs.kde.org/show_bug.cgi?id=324510
> 
> 
> Diffs
> -----
> 
>   shell/settings/ccsettings.ui 64d24e2 
>   shell/settings/ccpreferences.h 4ecf623 
>   shell/settings/ccpreferences.cpp 0347fc6 
>   shell/settings/ccconfig.kcfg 1bc89b1 
>   shell/completionsettings.h b3f28ce 
>   shell/completionsettings.cpp 6b6adf6 
>   interfaces/icompletionsettings.h eb615ae 
> 
> Diff: http://git.reviewboard.kde.org/r/112590/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vlas Puhov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130913/b93ed3c9/attachment.html>