Review Request 112590: Fix todo marker words and detailed completion settings not persistent across application restart.

[Vlas Puhov]

> On Sept. 8, 2013, 4:28 p.m., Andreas Pakulat wrote:
> > I think you didn't understand the existing code. At least in master the todo marker words are written out explicitly, the kcmodule support for named widgets is intentionally not used because the string from the field should apparently be split according to shell-rules and should then be put into a stringlist. Using the support for named widgets would break this as it would use a simple string to store the text entry.
> > 
> > Same goes for the completion detail setting, IIRC the kcmodule support for named widgets uses the text of the entry but it seems the code wants to rather use the index. I might be wrong on this one though.

Hmm... I didn't think about shell-rules. Thanks!
Still, I don't think it reason enough not to use kcmodule's feature. Marker words can be split afterward in todoMarkerWords() function.
   Also I forgot to mention that in ccconfig.kcfg "marker words" represented as StingList, but in GUI it's just a String. That's another reason why it didn't work before.

>>The kcmodule support for named widgets uses the text of the entry but it seems the code wants to rather use the index.

Thats exactly what I mentioned in FIXME note. And thats why I manually save/load settings for completion detail. 


- Vlas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112590/#review39580
-----------------------------------------------------------


On Sept. 8, 2013, 3:47 p.m., Vlas Puhov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112590/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2013, 3:47 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> CCPreferences class is written with use of KCModule, so all setting can be saved/loaded automatically. For that widget's names should start with kcfg_ prefix, but neither todoMarkerWords nor completionDetail had one, so this feature didn't work.
> 
> 
> This addresses bug 324510.
>     http://bugs.kde.org/show_bug.cgi?id=324510
> 
> 
> Diffs
> -----
> 
>   shell/completionsettings.h b3f28ce 
>   shell/completionsettings.cpp 6b6adf6 
>   shell/settings/ccconfig.kcfg 1bc89b1 
>   shell/settings/ccpreferences.h 4ecf623 
>   shell/settings/ccpreferences.cpp 0347fc6 
>   shell/settings/ccsettings.ui 64d24e2 
> 
> Diff: http://git.reviewboard.kde.org/r/112590/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vlas Puhov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130908/9cfe04bb/attachment.html>